You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/06/12 01:42:54 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Jackie-Jiang opened a new pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546
## Description
Currently the case sensitivity handling only applies to the BrokerRequest, but not to the PinotQuery inside the BrokerRequest.
This will cause inconsistent and unexpected behavior when the query engine uses PinotQuery.
Fix this issue by extending the case sensitivity handling to the PinotQuery if it exists.
Note that because SQL queries are also compiled to BrokerRequest, the case sensitivity handling already applies to both PQL and SQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f1f1c41`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5546 +/- ##
=========================================
Coverage ? 66.57%
=========================================
Files ? 1105
Lines ? 56908
Branches ? 8519
=========================================
Hits ? 37888
Misses ? 16218
Partials ? 2802
```
| Flag | Coverage Δ | |
|---|---|---|
| #integrationtests | `45.38% <81.81%> (?)` | |
| #unittests | `56.73% <15.90%> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `39.02% <ø> (ø)` | |
| [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `69.46% <42.85%> (ø)` | |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `78.88% <88.23%> (ø)` | |
| [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `89.28% <100.00%> (ø)` | |
| [.../assignment/instance/InstanceAssignmentDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VBc3NpZ25tZW50RHJpdmVyLmphdmE=) | `96.00% <0.00%> (ø)` | |
| [...he/pinot/common/utils/request/FilterQueryTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9GaWx0ZXJRdWVyeVRyZWUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...or/transform/function/ModuloTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vTW9kdWxvVHJhbnNmb3JtRnVuY3Rpb24uamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `100.00% <0.00%> (ø)` | |
| [...me/impl/dictionary/IntOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvSW50T25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `84.14% <0.00%> (ø)` | |
| [...inot/common/exception/SchemaNotFoundException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1NjaGVtYU5vdEZvdW5kRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [1099 more](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=footer). Last update [f1f1c41...135404d](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee commented on a change in pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
snleee commented on a change in pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#discussion_r439176537
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -40,6 +40,7 @@
public static final String LEAD_CONTROLLER_RESOURCE_NAME = "leadControllerResource";
public static final String LEAD_CONTROLLER_RESOURCE_ENABLED_KEY = "RESOURCE_ENABLED";
+ // TODO: Rename this config because it applies to both SQL and PQL
public static final String ENABLE_CASE_INSENSITIVE_PQL_KEY = "enable.case.insensitive.pql";
Review comment:
We can add something like `enable.case.sensitivity` and fall back to `enable.case.insensitive.pql`? Since it's a pretty simple change, we can include to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f1f1c41`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5546 +/- ##
=========================================
Coverage ? 66.57%
=========================================
Files ? 1105
Lines ? 56908
Branches ? 8519
=========================================
Hits ? 37888
Misses ? 16218
Partials ? 2802
```
| Flag | Coverage Δ | |
|---|---|---|
| #integrationtests | `45.38% <81.81%> (?)` | |
| #unittests | `56.73% <15.90%> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `39.02% <ø> (ø)` | |
| [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `69.46% <42.85%> (ø)` | |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `78.88% <88.23%> (ø)` | |
| [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=) | `89.28% <100.00%> (ø)` | |
| [...ot/pql/parsers/pql2/ast/StarExpressionAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9TdGFyRXhwcmVzc2lvbkFzdE5vZGUuamF2YQ==) | `100.00% <0.00%> (ø)` | |
| [...ator/transform/function/CastTransformFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci90cmFuc2Zvcm0vZnVuY3Rpb24vQ2FzdFRyYW5zZm9ybUZ1bmN0aW9uLmphdmE=) | `87.50% <0.00%> (ø)` | |
| [.../java/org/apache/pinot/common/request/GroupBy.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9Hcm91cEJ5LmphdmE=) | `34.91% <0.00%> (ø)` | |
| [...n/java/org/apache/pinot/core/common/Constants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ers/pql2/ast/PredicateParenthesisGroupAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVQYXJlbnRoZXNpc0dyb3VwQXN0Tm9kZS5qYXZh) | `75.00% <0.00%> (ø)` | |
| [...or/dociditerators/ExpressionScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9kb2NpZGl0ZXJhdG9ycy9FeHByZXNzaW9uU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `63.75% <0.00%> (ø)` | |
| ... and [1099 more](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=footer). Last update [f1f1c41...135404d](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@f1f1c41`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `2.94%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5546 +/- ##
=========================================
Coverage ? 56.78%
=========================================
Files ? 1104
Lines ? 56902
Branches ? 8516
=========================================
Hits ? 32312
Misses ? 22038
Partials ? 2552
```
| Flag | Coverage Δ | |
|---|---|---|
| #unittests | `56.78% <2.94%> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `21.95% <ø> (ø)` | |
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `17.96% <2.94%> (ø)` | |
| [.../apache/pinot/minion/exception/FatalException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhjZXB0aW9uL0ZhdGFsRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../data/manager/realtime/PinotFSSegmentUploader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUGlub3RGU1NlZ21lbnRVcGxvYWRlci5qYXZh) | `73.33% <0.00%> (ø)` | |
| [...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh) | `73.17% <0.00%> (ø)` | |
| [...gment/index/readers/BitmapInvertedIndexReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L3JlYWRlcnMvQml0bWFwSW52ZXJ0ZWRJbmRleFJlYWRlci5qYXZh) | `74.28% <0.00%> (ø)` | |
| [...aggregation/function/AggregationFunctionUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BZ2dyZWdhdGlvbkZ1bmN0aW9uVXRpbHMuamF2YQ==) | `77.27% <0.00%> (ø)` | |
| [...rg/apache/pinot/core/startree/OffHeapStarTree.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9PZmZIZWFwU3RhclRyZWUuamF2YQ==) | `45.76% <0.00%> (ø)` | |
| [...rg/apache/pinot/common/utils/helix/TableCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvaGVsaXgvVGFibGVDYWNoZS5qYXZh) | `70.73% <0.00%> (ø)` | |
| [...java/org/apache/pinot/spi/utils/EqualityUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvRXF1YWxpdHlVdGlscy5qYXZh) | `75.86% <0.00%> (ø)` | |
| ... and [1096 more](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=footer). Last update [f1f1c41...e74d3f0](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#discussion_r439645105
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -40,6 +40,7 @@
public static final String LEAD_CONTROLLER_RESOURCE_NAME = "leadControllerResource";
public static final String LEAD_CONTROLLER_RESOURCE_ENABLED_KEY = "RESOURCE_ENABLED";
+ // TODO: Rename this config because it applies to both SQL and PQL
public static final String ENABLE_CASE_INSENSITIVE_PQL_KEY = "enable.case.insensitive.pql";
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #5546: Handle case sensitivity for PinotQuery within BrokerRequest
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #5546:
URL: https://github.com/apache/incubator-pinot/pull/5546#issuecomment-643030356
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=h1) Report
> Merging [#5546](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `70.61%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5546 +/- ##
==========================================
- Coverage 66.44% 66.38% -0.07%
==========================================
Files 1075 1105 +30
Lines 54773 56988 +2215
Branches 8168 8529 +361
==========================================
+ Hits 36396 37832 +1436
- Misses 15700 16369 +669
- Partials 2677 2787 +110
```
| Flag | Coverage Δ | |
|---|---|---|
| #integrationtests | `45.10% <50.85%> (?)` | |
| #unittests | `56.91% <63.29%> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...quota/HelixExternalViewBasedQueryQuotaManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IZWxpeEV4dGVybmFsVmlld0Jhc2VkUXVlcnlRdW90YU1hbmFnZXIuamF2YQ==) | `67.87% <0.00%> (ø)` | |
| [...org/apache/pinot/common/function/FunctionInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRnVuY3Rpb25JbmZvLmphdmE=) | `73.33% <ø> (ø)` | |
| [...java/org/apache/pinot/common/segment/ReadMode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vc2VnbWVudC9SZWFkTW9kZS5qYXZh) | `66.66% <ø> (ø)` | |
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `39.02% <0.00%> (+0.92%)` | :arrow_up: |
| [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `80.28% <0.00%> (+1.11%)` | :arrow_up: |
| [...he/pinot/controller/util/AutoAddInvertedIndex.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL0F1dG9BZGRJbnZlcnRlZEluZGV4LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/pinot/core/common/BaseBlockValSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vQmFzZUJsb2NrVmFsU2V0LmphdmE=) | `3.03% <0.00%> (-1.32%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/common/DataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRGF0YVNvdXJjZS5qYXZh) | `100.00% <ø> (ø)` | |
| [...data/manager/realtime/DefaultSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvRGVmYXVsdFNlZ21lbnRDb21taXR0ZXIuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `0.00% <ø> (-63.64%)` | :arrow_down: |
| ... and [446 more](https://codecov.io/gh/apache/incubator-pinot/pull/5546/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=footer). Last update [fcc3144...b71fa29](https://codecov.io/gh/apache/incubator-pinot/pull/5546?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org