You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/18 07:35:57 UTC
[GitHub] [skywalking] wankai123 opened a new pull request, #9347: Dashboard: Add metrics associate and fix.
wankai123 opened a new pull request, #9347:
URL: https://github.com/apache/skywalking/pull/9347
- Add metrics associate.
- Fix `FaaS-Root` document link and topology service relation dashboard link.
- Fix `Mesh-Instance` metric `Throughput`.
- Fix `Mesh-Service-Relation` metric `Throughput` and `Proxy Sidecar Internal Latency in Nanoseconds (Client Response)`.
- Fix `Mesh-Instance-Relation` metric `Throughput`.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #9347: Dashboard: Add metrics association and fix.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9347:
URL: https://github.com/apache/skywalking/pull/9347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9347: Dashboard: Add metrics association and fix.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9347:
URL: https://github.com/apache/skywalking/pull/9347#discussion_r923047855
##########
docs/en/changes/changes.md:
##########
@@ -41,6 +41,11 @@
* Fix tag dropdown style.
* Hide the copy button when db.statement is empty.
* Fix legend metrics for topology.
+* Dashboard: Add metrics associate.
Review Comment:
```suggestion
* Dashboard: Add metrics association.
```
I think associate is a verb., right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on a diff in pull request #9347: Dashboard: Add metrics association and fix.
Posted by GitBox <gi...@apache.org>.
wankai123 commented on code in PR #9347:
URL: https://github.com/apache/skywalking/pull/9347#discussion_r923049111
##########
docs/en/changes/changes.md:
##########
@@ -41,6 +41,11 @@
* Fix tag dropdown style.
* Hide the copy button when db.statement is empty.
* Fix legend metrics for topology.
+* Dashboard: Add metrics associate.
Review Comment:
`association` is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9347: Dashboard: Add metrics association and fix.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #9347:
URL: https://github.com/apache/skywalking/pull/9347#discussion_r923048333
##########
docs/en/changes/changes.md:
##########
@@ -41,6 +41,11 @@
* Fix tag dropdown style.
* Hide the copy button when db.statement is empty.
* Fix legend metrics for topology.
+* Dashboard: Add metrics associate.
Review Comment:
Or do you mean make metrics associate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org