You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/03/25 20:45:24 UTC
[jira] Created: (HARMONY-5652) [classlib][pack200] max_locals
computed incorrectly for longs, doubles
[classlib][pack200] max_locals computed incorrectly for longs, doubles
----------------------------------------------------------------------
Key: HARMONY-5652
URL: https://issues.apache.org/jira/browse/HARMONY-5652
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: All pack200
Reporter: Andrew Cornwall
The value for max_locals is computed incorrectly for all methods which have long or double arguments (type J or type D). For instance, the max_locals for CpField's constructor:
public CPField(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {
super(name, descriptor, flags, attributes);
}
is showing up as max_locals=5, when it should be max_locals=6 (1 for this, 1, for name, 1 for descriptor, 2 for flags, 1 for attributes).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5652) [classlib][pack200] max_locals
computed incorrectly for longs, doubles
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5652:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] max_locals computed incorrectly for longs, doubles
> ----------------------------------------------------------------------
>
> Key: HARMONY-5652
> URL: https://issues.apache.org/jira/browse/HARMONY-5652
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Attachments: main.patch
>
>
> The value for max_locals is computed incorrectly for all methods which have long or double arguments (type J or type D). For instance, the max_locals for CpField's constructor:
> public CPField(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {
> super(name, descriptor, flags, attributes);
> }
> is showing up as max_locals=5, when it should be max_locals=6 (1 for this, 1, for name, 1 for descriptor, 2 for flags, 1 for attributes).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5652) [classlib][pack200] max_locals
computed incorrectly for longs, doubles
Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5652:
-------------------------------------
Attachment: main.patch
main.patch changes countArgs to countInvokeInterfaceArgs - I'm not sure if other fixes will be required as well. (Does anyone rely on maxLocal being the number of arguments?)
> [classlib][pack200] max_locals computed incorrectly for longs, doubles
> ----------------------------------------------------------------------
>
> Key: HARMONY-5652
> URL: https://issues.apache.org/jira/browse/HARMONY-5652
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Attachments: main.patch
>
>
> The value for max_locals is computed incorrectly for all methods which have long or double arguments (type J or type D). For instance, the max_locals for CpField's constructor:
> public CPField(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {
> super(name, descriptor, flags, attributes);
> }
> is showing up as max_locals=5, when it should be max_locals=6 (1 for this, 1, for name, 1 for descriptor, 2 for flags, 1 for attributes).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5652) [classlib][pack200] max_locals
computed incorrectly for longs, doubles
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5652.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
Patch applied at r641348. Please check it was applied as you expected.
> [classlib][pack200] max_locals computed incorrectly for longs, doubles
> ----------------------------------------------------------------------
>
> Key: HARMONY-5652
> URL: https://issues.apache.org/jira/browse/HARMONY-5652
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch
>
>
> The value for max_locals is computed incorrectly for all methods which have long or double arguments (type J or type D). For instance, the max_locals for CpField's constructor:
> public CPField(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {
> super(name, descriptor, flags, attributes);
> }
> is showing up as max_locals=5, when it should be max_locals=6 (1 for this, 1, for name, 1 for descriptor, 2 for flags, 1 for attributes).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5652) [classlib][pack200] max_locals
computed incorrectly for longs, doubles
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582315#action_12582315 ]
Sian January commented on HARMONY-5652:
---------------------------------------
Not sure about your question - I don't think we rely on maxLocals being the number of arguments in our code, but I'm not sure if that's quite what you meant...
> [classlib][pack200] max_locals computed incorrectly for longs, doubles
> ----------------------------------------------------------------------
>
> Key: HARMONY-5652
> URL: https://issues.apache.org/jira/browse/HARMONY-5652
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Assignee: Sian January
> Fix For: 5.0M6
>
> Attachments: main.patch
>
>
> The value for max_locals is computed incorrectly for all methods which have long or double arguments (type J or type D). For instance, the max_locals for CpField's constructor:
> public CPField(CPUTF8 name, CPUTF8 descriptor, long flags, List attributes) {
> super(name, descriptor, flags, attributes);
> }
> is showing up as max_locals=5, when it should be max_locals=6 (1 for this, 1, for name, 1 for descriptor, 2 for flags, 1 for attributes).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.