[GitHub] [kafka] Schm1tz1 commented on a diff in pull request #12992: KAFKA-14376-KIP887: Add ConfigProvider to make use of environment variables

["Schm1tz1 (via GitHub)" <gi...@apache.org>]

Schm1tz1 commented on code in PR #12992:
URL: https://github.com/apache/kafka/pull/12992#discussion_r1155158455


##########
clients/src/test/java/org/apache/kafka/common/config/provider/EnvVarConfigProviderTest.java:
##########
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.common.config.provider;
+
+import org.apache.kafka.common.config.ConfigData;
+import org.apache.kafka.common.config.ConfigException;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.Arrays;
+import java.util.Set;
+import java.util.Map;
+import java.util.HashSet;
+import java.util.HashMap;
+
+import static org.apache.kafka.common.config.provider.EnvVarConfigProvider.ENV_VAR_CONFIG_PROVIDER_PATTERN_CONFIG;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+class EnvVarConfigProviderTest {
+
+    private EnvVarConfigProvider envVarConfigProvider = null;
+    @BeforeEach
+    public void setup() {
+        Map<String, String> testEnvVars = new HashMap<String, String>() {
+            {
+                put("test_var1", "value1");
+                put("secret_var2", "value2");
+                put("new_var3", "value3");
+            }
+        };
+        envVarConfigProvider = new EnvVarConfigProvider(testEnvVars);
+        envVarConfigProvider.configure(Collections.singletonMap("", ""));
+    }
+
+    @Test
+    void testGetAllEnvVarsNotEmpty() {
+        ConfigData properties = envVarConfigProvider.get("");
+        assertNotEquals(0, properties.data().size());
+    }
+
+    @Test
+    void testGetMultipleKeysAndCompare() {
+        ConfigData properties = envVarConfigProvider.get("");
+        assertNotEquals(0, properties.data().size());
+        assertEquals("value1", properties.data().get("test_var1"));
+        assertEquals("value2", properties.data().get("secret_var2"));
+        assertEquals("value3", properties.data().get("new_var3"));
+    }
+
+    @Test
+    public void testGetOneKeyWithNullPath() {
+        ConfigData config = envVarConfigProvider.get(null, Collections.singleton("secret_var2"));
+        Map<String, String> data = config.data();
+
+        assertEquals(1, data.size());
+        assertEquals("value2", data.get("secret_var2"));
+    }
+
+    @Test
+    public void testGetOneKeyWithEmptyPath() {
+        ConfigData config = envVarConfigProvider.get("", Collections.singleton("test_var1"));
+        Map<String, String> data = config.data();
+
+        assertEquals(1, data.size());
+        assertEquals("value1", data.get("test_var1"));
+    }
+
+    @Test
+    void testGetWhitelistedEnvVars() {
+        Set<String> whiteList = new HashSet<>(Arrays.asList("test_var1", "secret_var2"));
+        Set<String> keys = envVarConfigProvider.get(null, whiteList).data().keySet();
+        assertEquals(whiteList, keys);
+    }
+    @Test
+    void testNotNullPathNonEmptyThrowsException() {
+        assertThrows(ConfigException.class, () -> envVarConfigProvider.get("test-path", Collections.singleton("test_var1")));
+    }
+
+    @Test void testRegExpEnvVars() {
+        Map<String, String> testConfigMap = Collections.singletonMap(ENV_VAR_CONFIG_PROVIDER_PATTERN_CONFIG, "secret_.*");
+        envVarConfigProvider.configure(testConfigMap);
+
+        assertEquals(1, envVarConfigProvider.get(null, Collections.singleton("secret_var2")).data().size());

Review Comment:
   Of course - thanks for pointing that out. It doesn't pass because I am using the `asPredicate` method. Added a more detailed test case but not sure about `asMatchPredicate` because ist not Java 8 compatible (was added in 11). It's added and tested locally but not yet pushed. Might need to use the matcher instead to stay compatible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org