You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2026/09/09 03:14:02 UTC
[PR] Simplify Android colour structure [cordova-android]
dpogue opened a new pull request, #2016:
URL: https://github.com/apache/cordova-android/pull/2016
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
To avoid run-time parsing of colours from config.xml, it would be best if the prepare step could set the colours properly in cdv_colors.xml as resources.
### Description
<!-- Describe your changes in detail -->
Restructured the cdv_colors.xml file so that the default/system background is a separate variable that gets changed based on .
* Set up `cdv_background_color` so it defaults to the system background
* To be set from the `BackgroundColor` preference in config.xml
* Added a `cdv_status_bar_background` color resource that defaults to transparent
* To be set from the `StatusBarBackgroundColor` preference in config.xml
* Retain `cdv_splashscreen_background` defaulting to the `cdv_background_color`
* To be set from the `SplashScreenBackgroundColor` preference in config.xml
### TODO
- [ ] Actually setting the colour override values during prepare based on the preferences
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] WIP Simplify Android colour structure [cordova-android]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2016:
URL: https://github.com/apache/cordova-android/pull/2016#issuecomment-5595226629
## [Codecov](https://app.codecov.io/gh/apache/cordova-android/pull/2016?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 61.68%. Comparing base ([`a9a4511`](https://app.codecov.io/gh/apache/cordova-android/commit/a9a4511c629e930d4521b6ae8b6d9369e8a0b002?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e309e6d`](https://app.codecov.io/gh/apache/cordova-android/commit/e309e6ddaf7de949840ea48cb29aecae00a5abd9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #2016 +/- ##
==========================================
- Coverage 63.20% 61.68% -1.53%
==========================================
Files 24 24
Lines 4922 4922
==========================================
- Hits 3111 3036 -75
- Misses 1811 1886 +75
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cordova-android/pull/2016?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org