You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by guoyuepeng <gi...@git.apache.org> on 2018/12/05 15:24:28 UTC
[GitHub] griffin pull request #466: Remove incubator
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/griffin/pull/466
Remove incubator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin remove_incubator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/griffin/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit d9cd1d7026556b67c07b9b83834694806ab6eac6
Author: William Guo <gu...@...>
Date: 2018-12-05T15:06:50Z
update merge script
commit a40873ac0d7c3638513eb8c15a278c45ac373847
Author: William Guo <gu...@...>
Date: 2018-12-05T15:23:48Z
remove all incubator words
----
---
[GitHub] griffin pull request #466: Remove incubator
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/griffin/pull/466
---
[GitHub] griffin pull request #466: Remove incubator
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on a diff in the pull request:
https://github.com/apache/griffin/pull/466#discussion_r239704437
--- Diff: ui/angular/src/app/app.component.html ---
@@ -49,9 +49,9 @@
<li class="divider"></li>
<li><a href="https://griffin.incubator.apache.org/" target="_blank"><i class="fa fa-home fa-fw"></i> Home
--- End diff --
pls update this.
---
[GitHub] griffin issue #466: Remove incubator
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/466
it is already fixed in pr466. Something is wrong with github.com/apache/griffin. it is not synced with apache repo.
---
[GitHub] griffin issue #466: Remove incubator
Posted by bhlx3lyx7 <gi...@git.apache.org>.
Github user bhlx3lyx7 commented on the issue:
https://github.com/apache/griffin/pull/466
Seems like we need to remove DISCLAIMER file like: https://github.com/apache/servicecomb-java-chassis/commit/0cb194b384c6edd99a26c11054dd6723307c9b84
---
[GitHub] griffin issue #466: Remove incubator
Posted by bhlx3lyx7 <gi...@git.apache.org>.
Github user bhlx3lyx7 commented on the issue:
https://github.com/apache/griffin/pull/466
@ahutsunshine the repo of homepage is another one for griffin-site
---
[GitHub] griffin issue #466: Remove incubator
Posted by toyboxman <gi...@git.apache.org>.
Github user toyboxman commented on the issue:
https://github.com/apache/griffin/pull/466
LGTM
---
[GitHub] griffin pull request #466: Remove incubator
Posted by guoyuepeng <gi...@git.apache.org>.
GitHub user guoyuepeng reopened a pull request:
https://github.com/apache/griffin/pull/466
Remove incubator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/incubator-griffin remove_incubator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/griffin/pull/466.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #466
----
commit d9cd1d7026556b67c07b9b83834694806ab6eac6
Author: William Guo <gu...@...>
Date: 2018-12-05T15:06:50Z
update merge script
commit a40873ac0d7c3638513eb8c15a278c45ac373847
Author: William Guo <gu...@...>
Date: 2018-12-05T15:23:48Z
remove all incubator words
commit 1885a613a230b50cd8323169627cd5b244352008
Author: William Guo <gu...@...>
Date: 2018-12-05T15:29:49Z
replace incubators
----
---
[GitHub] griffin pull request #466: Remove incubator
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng closed the pull request at:
https://github.com/apache/griffin/pull/466
---
[GitHub] griffin issue #466: Remove incubator
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on the issue:
https://github.com/apache/griffin/pull/466
@guoyuepeng I find two places. One is References - Home Page in README.md and the other is `<a href="https://griffin.incubator.apache.org/" target="_blank">` in ui/angular/src/app/app.component.html.
---
Re: (External Email) [GitHub] griffin issue #466: Remove incubator
Posted by "Afshin, Bardia" <ba...@changehealthcare.com>.
unsubscribe
On 12/6/18, 4:22 AM, "guoyuepeng" <gi...@git.apache.org> wrote:
Github user guoyuepeng commented on the issue:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgriffin%2Fpull%2F466&data=02%7C01%7Cbardia.afshin%40changehealthcare.com%7C3c8f92693f3b46e3fe4108d65b756f37%7Cd13a3cbde4ce45e191c298859a236439%7C0%7C0%7C636796957266064760&sdata=U7kf9kAgAKhhFr5ex%2BB%2FYU1RXYQXc7EEc5DvFKVcHK4%3D&reserved=0
> Why does griffin homepage link still use https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgriffin.incubator.apache.org&data=02%7C01%7Cbardia.afshin%40changehealthcare.com%7C3c8f92693f3b46e3fe4108d65b756f37%7Cd13a3cbde4ce45e191c298859a236439%7C0%7C0%7C636796957266064760&sdata=vk0734c6FYS%2BWajiOa4lEtaFYcKL6%2BG%2FJ1oaHltc6tk%3D&reserved=0 instead of https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgriffin.apache.org%2F&data=02%7C01%7Cbardia.afshin%40changehealthcare.com%7C3c8f92693f3b46e3fe4108d65b756f37%7Cd13a3cbde4ce45e191c298859a236439%7C0%7C0%7C636796957266064760&sdata=Gk02sZR9%2BQyZ60VJkN8w%2FMCUod%2FYeS7yffPc8b4Bd6Q%3D&reserved=0? Others look good to me.
Where do you find the link of https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgriffin.incubator.apache.org&data=02%7C01%7Cbardia.afshin%40changehealthcare.com%7C3c8f92693f3b46e3fe4108d65b756f37%7Cd13a3cbde4ce45e191c298859a236439%7C0%7C0%7C636796957266064760&sdata=vk0734c6FYS%2BWajiOa4lEtaFYcKL6%2BG%2FJ1oaHltc6tk%3D&reserved=0, our home page is https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgriffin.apache.org&data=02%7C01%7Cbardia.afshin%40changehealthcare.com%7C3c8f92693f3b46e3fe4108d65b756f37%7Cd13a3cbde4ce45e191c298859a236439%7C0%7C0%7C636796957266064760&sdata=cKaAqG%2BkimmYIjp8TQ5AJTLSN3kxkEFziSVlVt81Bcw%3D&reserved=0
---
This message is confidential, intended only for the named recipient(s) and may contain information that is privileged or exempt from disclosure under applicable law. If you are not the intended recipient(s), you are notified that the dissemination, distribution, or copying of this message is strictly prohibited. If you receive this message in error or are not the named recipient(s), please notify the sender by return email and delete this message. Thank you.
[GitHub] griffin issue #466: Remove incubator
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/466
> Why does griffin homepage link still use https://griffin.incubator.apache.org instead of https://griffin.apache.org/? Others look good to me.
Where do you find the link of https://griffin.incubator.apache.org, our home page is https://griffin.apache.org
---
[GitHub] griffin issue #466: Remove incubator
Posted by ahutsunshine <gi...@git.apache.org>.
Github user ahutsunshine commented on the issue:
https://github.com/apache/griffin/pull/466
Why does griffin homepage link still use https://griffin.incubator.apache.org instead of https://griffin.apache.org/? Others look good to me.
---