You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Henry Saputra (JIRA)" <ji...@apache.org> on 2010/05/18 02:42:42 UTC
[jira] Created: (SHINDIG-1333) Change variable and param name for
Feature instance from 'f' to 'feature' to be consistent with naming
convention
Change variable and param name for Feature instance from 'f' to 'feature' to be consistent with naming convention
-----------------------------------------------------------------------------------------------------------------
Key: SHINDIG-1333
URL: https://issues.apache.org/jira/browse/SHINDIG-1333
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: 2.0.0-RC1
Reporter: Henry Saputra
Priority: Trivial
To make the code cleaner, change the name of the variable and param name from f to feature in TemplateRewriter.
This should make the naming consistent with the rest of the code.
Code review at
http://codereview.appspot.com/1196042/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1333) Change variable and param name for
Feature instance from 'f' to 'feature' to be consistent with naming
convention
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1333:
-----------------------------------
Comment: was deleted
(was: Pathc fix for this jira)
> Change variable and param name for Feature instance from 'f' to 'feature' to be consistent with naming convention
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1333
> URL: https://issues.apache.org/jira/browse/SHINDIG-1333
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0-RC1
> Reporter: Henry Saputra
> Priority: Trivial
> Attachments: clean_feature_var.patch
>
>
> To make the code cleaner, change the name of the variable and param name from f to feature in TemplateRewriter.
> This should make the naming consistent with the rest of the code.
> Code review at
> http://codereview.appspot.com/1196042/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1333) Change variable and param name for
Feature instance from 'f' to 'feature' to be consistent with naming
convention
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1333.
-----------------------------------
Fix Version/s: 2.0.0-RC1
Resolution: Fixed
thanks!
> Change variable and param name for Feature instance from 'f' to 'feature' to be consistent with naming convention
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1333
> URL: https://issues.apache.org/jira/browse/SHINDIG-1333
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0-RC1
> Reporter: Henry Saputra
> Priority: Trivial
> Fix For: 2.0.0-RC1
>
> Attachments: clean_feature_var.patch
>
>
> To make the code cleaner, change the name of the variable and param name from f to feature in TemplateRewriter.
> This should make the naming consistent with the rest of the code.
> Code review at
> http://codereview.appspot.com/1196042/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1333) Change variable and param name for
Feature instance from 'f' to 'feature' to be consistent with naming
convention
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1333:
-----------------------------------
Attachment: clean_feature_var.patch
Patch for this jira
> Change variable and param name for Feature instance from 'f' to 'feature' to be consistent with naming convention
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1333
> URL: https://issues.apache.org/jira/browse/SHINDIG-1333
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0-RC1
> Reporter: Henry Saputra
> Priority: Trivial
> Attachments: clean_feature_var.patch
>
>
> To make the code cleaner, change the name of the variable and param name from f to feature in TemplateRewriter.
> This should make the naming consistent with the rest of the code.
> Code review at
> http://codereview.appspot.com/1196042/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1333) Change variable and param name for
Feature instance from 'f' to 'feature' to be consistent with naming
convention
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1333:
-----------------------------------
Attachment: (was: clean_feature_var.patch)
> Change variable and param name for Feature instance from 'f' to 'feature' to be consistent with naming convention
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1333
> URL: https://issues.apache.org/jira/browse/SHINDIG-1333
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0-RC1
> Reporter: Henry Saputra
> Priority: Trivial
> Attachments: clean_feature_var.patch
>
>
> To make the code cleaner, change the name of the variable and param name from f to feature in TemplateRewriter.
> This should make the naming consistent with the rest of the code.
> Code review at
> http://codereview.appspot.com/1196042/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1333) Change variable and param name for
Feature instance from 'f' to 'feature' to be consistent with naming
convention
Posted by "Henry Saputra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1333:
-----------------------------------
Attachment: clean_feature_var.patch
Pathc fix for this jira
> Change variable and param name for Feature instance from 'f' to 'feature' to be consistent with naming convention
> -----------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1333
> URL: https://issues.apache.org/jira/browse/SHINDIG-1333
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.0-RC1
> Reporter: Henry Saputra
> Priority: Trivial
> Attachments: clean_feature_var.patch
>
>
> To make the code cleaner, change the name of the variable and param name from f to feature in TemplateRewriter.
> This should make the naming consistent with the rest of the code.
> Code review at
> http://codereview.appspot.com/1196042/show
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.