You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by sz...@apache.org on 2022/07/15 18:18:51 UTC

[iceberg] branch master updated: Spark: Remove stack trace from log for filter pushdown failure (#5274)

This is an automated email from the ASF dual-hosted git repository.

szehon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 64ed2a7e2 Spark: Remove stack trace from log for filter pushdown failure (#5274)
64ed2a7e2 is described below

commit 64ed2a7e2b5f7acce921e6d2c40d97ef276c44e8
Author: Huaxin Gao <hu...@apple.com>
AuthorDate: Fri Jul 15 11:18:46 2022 -0700

    Spark: Remove stack trace from log for filter pushdown failure (#5274)
---
 .../java/org/apache/iceberg/spark/source/SparkScanBuilder.java    | 8 ++++----
 .../java/org/apache/iceberg/spark/source/SparkScanBuilder.java    | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java b/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
index c44541694..60d2c2150 100644
--- a/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
+++ b/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
@@ -108,8 +108,8 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
         expr = SparkFilters.convert(filter);
       } catch (IllegalArgumentException e) {
         // converting to Iceberg Expression failed, so this expression cannot be pushed down
-        LOG.warn("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}",
-            filter, e);
+        LOG.info("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}. {}",
+            filter, e.getMessage());
       }
 
       if (expr != null) {
@@ -119,8 +119,8 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
           pushed.add(filter);
         } catch (ValidationException e) {
           // binding to the table schema failed, so this expression cannot be pushed down
-          LOG.warn("Failed to bind expression to table schema, skipping push down for this expression: {}",
-              filter, e);
+          LOG.info("Failed to bind expression to table schema, skipping push down for this expression: {}. {}",
+              filter, e.getMessage());
         }
       }
     }
diff --git a/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java b/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
index c44541694..60d2c2150 100644
--- a/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
+++ b/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
@@ -108,8 +108,8 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
         expr = SparkFilters.convert(filter);
       } catch (IllegalArgumentException e) {
         // converting to Iceberg Expression failed, so this expression cannot be pushed down
-        LOG.warn("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}",
-            filter, e);
+        LOG.info("Failed to convert filter to Iceberg expression, skipping push down for this expression: {}. {}",
+            filter, e.getMessage());
       }
 
       if (expr != null) {
@@ -119,8 +119,8 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
           pushed.add(filter);
         } catch (ValidationException e) {
           // binding to the table schema failed, so this expression cannot be pushed down
-          LOG.warn("Failed to bind expression to table schema, skipping push down for this expression: {}",
-              filter, e);
+          LOG.info("Failed to bind expression to table schema, skipping push down for this expression: {}. {}",
+              filter, e.getMessage());
         }
       }
     }