You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/08/04 21:25:19 UTC
Review Request 37093: When regenerating Kerberos principals,
ensure Kerberos Descriptor changes are applied to services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37093/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Jonathan Hurley, John Speidel, and Robert Nettleton.
Bugs: AMBARI-12604
https://issues.apache.org/jira/browse/AMBARI-12604
Repository: ambari
Description
-------
When regenerating Kerberos principals, ensure Kerberos Descriptor changes are applied to services.
It is possible for changes to be made to the Kerberos Descriptor. One way to propagate these changes into the service configurations is to process the Kerberos Descriptor and update service configurations while performing tasks for the "Regenerate Keytabs" operation.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java d9ae5d5
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 57e5527
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 9caf7df
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 55f75ad
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java f2484e6
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 467c3ac
Diff: https://reviews.apache.org/r/37093/diff/
Testing
-------
Manually tested on trunk and branch-2.1
#Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48:04.515s
[INFO] Finished at: Tue Aug 04 15:09:21 EDT 2015
[INFO] Final Memory: 65M/1376M
[INFO] ------------------------------------------------------------------------
#Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 37093: When regenerating Kerberos principals,
ensure Kerberos Descriptor changes are applied to services
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37093/#review94233
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 4, 2015, 3:25 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37093/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 3:25 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jonathan Hurley, John Speidel, and Robert Nettleton.
>
>
> Bugs: AMBARI-12604
> https://issues.apache.org/jira/browse/AMBARI-12604
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When regenerating Kerberos principals, ensure Kerberos Descriptor changes are applied to services.
>
> It is possible for changes to be made to the Kerberos Descriptor. One way to propagate these changes into the service configurations is to process the Kerberos Descriptor and update service configurations while performing tasks for the "Regenerate Keytabs" operation.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java d9ae5d5
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 57e5527
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 9caf7df
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 55f75ad
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java f2484e6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 467c3ac
>
> Diff: https://reviews.apache.org/r/37093/diff/
>
>
> Testing
> -------
>
> Manually tested on trunk and branch-2.1
>
> #Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48:04.515s
> [INFO] Finished at: Tue Aug 04 15:09:21 EDT 2015
> [INFO] Final Memory: 65M/1376M
> [INFO] ------------------------------------------------------------------------
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 37093: When regenerating Kerberos principals,
ensure Kerberos Descriptor changes are applied to services
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37093/#review94234
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Aug. 4, 2015, 7:25 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37093/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 7:25 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Jonathan Hurley, John Speidel, and Robert Nettleton.
>
>
> Bugs: AMBARI-12604
> https://issues.apache.org/jira/browse/AMBARI-12604
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When regenerating Kerberos principals, ensure Kerberos Descriptor changes are applied to services.
>
> It is possible for changes to be made to the Kerberos Descriptor. One way to propagate these changes into the service configurations is to process the Kerberos Descriptor and update service configurations while performing tasks for the "Regenerate Keytabs" operation.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java d9ae5d5
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java 57e5527
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 9caf7df
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 55f75ad
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/UpdateKerberosConfigsServerAction.java f2484e6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 467c3ac
>
> Diff: https://reviews.apache.org/r/37093/diff/
>
>
> Testing
> -------
>
> Manually tested on trunk and branch-2.1
>
> #Local test results:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 48:04.515s
> [INFO] Finished at: Tue Aug 04 15:09:21 EDT 2015
> [INFO] Final Memory: 65M/1376M
> [INFO] ------------------------------------------------------------------------
>
> #Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>