You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/04/28 16:26:23 UTC

[Impala-ASF-CR] IMPALA-12106: Fix overparallelization of Union fragment by 1

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19816


Change subject: IMPALA-12106: Fix overparallelization of Union fragment by 1
......................................................................

IMPALA-12106: Fix overparallelization of Union fragment by 1

IMPALA-10973 has a bug where a union fragment without a scan node can be
over-parallelized by the backend scheduler by 1. It is reproducible by
running TPC-DS Q11 with MT_DOP=1. This patch additionally checks that
such a fragment does not have an input fragment before randomizing the
host assignment.

Testing:
Add TPC-DS Q11 to test_mt_dop.py::TestMtDopScheduling::test_scheduling
and verify the number of fragment instances scheduled in the
ExecSummary.

Change-Id: Ic69e7c8c0cadb4b07ee398aff362fbc6513eb08d
---
M be/src/scheduling/scheduler.cc
M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test
2 files changed, 180 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/19816/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic69e7c8c0cadb4b07ee398aff362fbc6513eb08d
Gerrit-Change-Number: 19816
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12106: Fix overparallelization of Union fragment by 1

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.

Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19816 )

Change subject: IMPALA-12106: Fix overparallelization of Union fragment by 1
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19816/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test
File testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test:

http://gerrit.cloudera.org:8080/#/c/19816/1/testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test@310
PS1, Line 310: ====
nit: not necessary



-- 
To view, visit http://gerrit.cloudera.org:8080/19816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69e7c8c0cadb4b07ee398aff362fbc6513eb08d
Gerrit-Change-Number: 19816
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 May 2023 16:44:11 +0000
Gerrit-HasComments: Yes