You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/08/30 00:25:42 UTC
svn commit: r690412 -
/maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Author: vsiveton
Date: Fri Aug 29 15:25:42 2008
New Revision: 690412
URL: http://svn.apache.org/viewvc?rev=690412&view=rev
Log:
o fixed typo
Modified:
maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Modified: maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java?rev=690412&r1=690411&r2=690412&view=diff
==============================================================================
--- maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java (original)
+++ maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java Fri Aug 29 15:25:42 2008
@@ -530,7 +530,7 @@
if ( ( detail || medium ) && !minimal )
{
append( buffer, "This plugin has " + pd.getMojos().size() + " goal"
- + ( pd.getMojos().size() > 1 ? "" : "s" ) + ":", 0 );
+ + ( pd.getMojos().size() > 1 ? "s" : "" ) + ":", 0 );
buffer.append( "\n" );
List mojos = pd.getMojos();
Re: svn commit: r690412 - /maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Posted by Vincent Siveton <vi...@gmail.com>.
Hi Dennis,
2008/8/31 Dennis Lundberg <de...@apache.org>:
> Is this grammatically correct for the case when there are no goals? Can
> we get some help from a native English speaker. Should it be
>
> a. This plugin has 0 goal:
> b. This plugin has 0 goals:
>
Neither, just a beautiful NPE. I will fix it.
Cheers,
Vincent
> vsiveton@apache.org wrote:
>> Author: vsiveton
>> Date: Fri Aug 29 15:25:42 2008
>> New Revision: 690412
>>
>> URL: http://svn.apache.org/viewvc?rev=690412&view=rev
>> Log:
>> o fixed typo
>>
>> Modified:
>> maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
>>
>> Modified: maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
>> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java?rev=690412&r1=690411&r2=690412&view=diff
>> ==============================================================================
>> --- maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java (original)
>> +++ maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java Fri Aug 29 15:25:42 2008
>> @@ -530,7 +530,7 @@
>> if ( ( detail || medium ) && !minimal )
>> {
>> append( buffer, "This plugin has " + pd.getMojos().size() + " goal"
>> - + ( pd.getMojos().size() > 1 ? "" : "s" ) + ":", 0 );
>> + + ( pd.getMojos().size() > 1 ? "s" : "" ) + ":", 0 );
>> buffer.append( "\n" );
>>
>> List mojos = pd.getMojos();
>>
>>
>>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r690412 - /maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Posted by Stephen Connolly <st...@gmail.com>.
0 goals
1 goal
2 goals
Sent from my iPod
On 31 Aug 2008, at 10:57, Dennis Lundberg <de...@apache.org> wrote:
> Is this grammatically correct for the case when there are no goals?
> Can
> we get some help from a native English speaker. Should it be
>
> a. This plugin has 0 goal:
> b. This plugin has 0 goals:
>
> vsiveton@apache.org wrote:
>> Author: vsiveton
>> Date: Fri Aug 29 15:25:42 2008
>> New Revision: 690412
>>
>> URL: http://svn.apache.org/viewvc?rev=690412&view=rev
>> Log:
>> o fixed typo
>>
>> Modified:
>> maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/
>> maven/plugins/help/DescribeMojo.java
>>
>> Modified: maven/plugins/trunk/maven-help-plugin/src/main/java/org/
>> apache/maven/plugins/help/DescribeMojo.java
>> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java?rev=690412&r1=690411&r2=690412&view=diff
>> ===
>> ===
>> ===
>> =====================================================================
>> --- maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/
>> maven/plugins/help/DescribeMojo.java (original)
>> +++ maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/
>> maven/plugins/help/DescribeMojo.java Fri Aug 29 15:25:42 2008
>> @@ -530,7 +530,7 @@
>> if ( ( detail || medium ) && !minimal )
>> {
>> append( buffer, "This plugin has " +
>> pd.getMojos().size() + " goal"
>> - + ( pd.getMojos().size() > 1 ? "" : "s" ) + ":",
>> 0 );
>> + + ( pd.getMojos().size() > 1 ? "s" : "" ) + ":",
>> 0 );
>> buffer.append( "\n" );
>>
>> List mojos = pd.getMojos();
>>
>>
>>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r690412 - /maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
Posted by Dennis Lundberg <de...@apache.org>.
Is this grammatically correct for the case when there are no goals? Can
we get some help from a native English speaker. Should it be
a. This plugin has 0 goal:
b. This plugin has 0 goals:
vsiveton@apache.org wrote:
> Author: vsiveton
> Date: Fri Aug 29 15:25:42 2008
> New Revision: 690412
>
> URL: http://svn.apache.org/viewvc?rev=690412&view=rev
> Log:
> o fixed typo
>
> Modified:
> maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
>
> Modified: maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java?rev=690412&r1=690411&r2=690412&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java (original)
> +++ maven/plugins/trunk/maven-help-plugin/src/main/java/org/apache/maven/plugins/help/DescribeMojo.java Fri Aug 29 15:25:42 2008
> @@ -530,7 +530,7 @@
> if ( ( detail || medium ) && !minimal )
> {
> append( buffer, "This plugin has " + pd.getMojos().size() + " goal"
> - + ( pd.getMojos().size() > 1 ? "" : "s" ) + ":", 0 );
> + + ( pd.getMojos().size() > 1 ? "s" : "" ) + ":", 0 );
> buffer.append( "\n" );
>
> List mojos = pd.getMojos();
>
>
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org