You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Navina Ramesh <nr...@linkedin.com> on 2016/07/29 20:58:58 UTC
Review Request 50614: SAMZA-970 - Problems with integration tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/
-----------------------------------------------------------
Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
Bugs: SAMZA-987
https://issues.apache.org/jira/browse/SAMZA-987
Repository: samza
Description
-------
SAMZA-987 - Preparing for 0.10.1 version release
Diffs
-----
bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
Diff: https://reviews.apache.org/r/50614/diff/
Testing
-------
./bin/check-all.sh
Thanks,
Navina Ramesh
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144208
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On July 29, 2016, 9:37 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:37 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Navina Ramesh <nr...@linkedin.com>.
> On July 29, 2016, 9:58 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/startup/hello-samza/versioned/index.md, line 30
> > <https://reviews.apache.org/r/50614/diff/2/?file=1458209#file1458209line30>
> >
> > Before we push out the online doc and after the official 0.10.1 released artifacts are in central maven, we should update hello-samza project s.t. the master points to 0.10.1 and latest points to 0.11-SNAPSHOT.
Yeah. Makes sense!
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144207
-----------------------------------------------------------
On July 29, 2016, 9:37 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:37 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144207
-----------------------------------------------------------
docs/startup/hello-samza/versioned/index.md
<https://reviews.apache.org/r/50614/#comment210212>
Before we push out the online doc and after the official 0.10.1 released artifacts are in central maven, we should update hello-samza project s.t. the master points to 0.10.1 and latest points to 0.11-SNAPSHOT.
- Yi Pan (Data Infrastructure)
On July 29, 2016, 9:37 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:37 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Fred Ji <fj...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144225
-----------------------------------------------------------
docs/_config.yml (line 26)
<https://reviews.apache.org/r/50614/#comment210226>
[Info] why not keep it as latest?
- Fred Ji
On July 29, 2016, 9:37 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:37 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/
-----------------------------------------------------------
(Updated July 29, 2016, 9:37 p.m.)
Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
Changes
-------
Fixed the website versioning
Bugs: SAMZA-987
https://issues.apache.org/jira/browse/SAMZA-987
Repository: samza
Description
-------
SAMZA-987 - Preparing for 0.10.1 version release
Diffs (updated)
-----
bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
Diff: https://reviews.apache.org/r/50614/diff/
Testing
-------
./bin/check-all.sh
Thanks,
Navina Ramesh
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144200
-----------------------------------------------------------
docs/_config.yml (line 26)
<https://reviews.apache.org/r/50614/#comment210206>
Actually, I am unclear about Line 28
- Navina Ramesh
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Navina Ramesh <nr...@linkedin.com>.
> On July 29, 2016, 9:20 p.m., Jake Maes wrote:
> > docs/_config.yml, line 26
> > <https://reviews.apache.org/r/50614/diff/1/?file=1458161#file1458161line26>
> >
> > This is the only change I'm unclear on.
> >
> > Does this affect the ".../latest/..." URL in the documentation site? If so, it seems we wouldn't want to change it.
Yeah. I wasn't clear either. I just followed Yi's patch from 0.10.0 release :)
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144198
-----------------------------------------------------------
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Navina Ramesh <nr...@linkedin.com>.
> On July 29, 2016, 9:20 p.m., Jake Maes wrote:
> > docs/_config.yml, line 26
> > <https://reviews.apache.org/r/50614/diff/1/?file=1458161#file1458161line26>
> >
> > This is the only change I'm unclear on.
> >
> > Does this affect the ".../latest/..." URL in the documentation site? If so, it seems we wouldn't want to change it.
>
> Navina Ramesh wrote:
> Yeah. I wasn't clear either. I just followed Yi's patch from 0.10.0 release :)
>
> Yi Pan (Data Infrastructure) wrote:
> Yes. It will. That's why in the whole release process, there is an annoying step to "publish online doc twice", i.e. switch to 0.10.1 branch, publish the online site once, then switch back to master, publish the online site one more time, s.t. the versioned and the latest sites are set to 0.10.1 and 0.11-SNAPSHOT respectively.
Yep. There's your reason :P
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144198
-----------------------------------------------------------
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
> On July 29, 2016, 9:20 p.m., Jake Maes wrote:
> > docs/_config.yml, line 26
> > <https://reviews.apache.org/r/50614/diff/1/?file=1458161#file1458161line26>
> >
> > This is the only change I'm unclear on.
> >
> > Does this affect the ".../latest/..." URL in the documentation site? If so, it seems we wouldn't want to change it.
>
> Navina Ramesh wrote:
> Yeah. I wasn't clear either. I just followed Yi's patch from 0.10.0 release :)
Yes. It will. That's why in the whole release process, there is an annoying step to "publish online doc twice", i.e. switch to 0.10.1 branch, publish the online site once, then switch back to master, publish the online site one more time, s.t. the versioned and the latest sites are set to 0.10.1 and 0.11-SNAPSHOT respectively.
- Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144198
-----------------------------------------------------------
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Jake Maes <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144198
-----------------------------------------------------------
Fix it, then Ship it!
docs/_config.yml (line 26)
<https://reviews.apache.org/r/50614/#comment210202>
This is the only change I'm unclear on.
Does this affect the ".../latest/..." URL in the documentation site? If so, it seems we wouldn't want to change it.
- Jake Maes
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
> On July 29, 2016, 9:30 p.m., Yi Pan (Data Infrastructure) wrote:
> > docs/_config.yml, line 26
> > <https://reviews.apache.org/r/50614/diff/1/?file=1458161#file1458161line26>
> >
> > Single quotation marks are mandatory here. Otherwise, the tool we use will parse this as a float number and fail.
> >
> > Also, we have never publised a 0.x.1 online doc site since 0.8. It should be OK if we just overwrite the current 0.10 online doc site.
OK. I take it back. 0.10.1 should compile fine, as we have 0.7.0 before. 0.10 will be treated as float number and make it 0.1 version, which is not OK.
Anyways, I found adding the single quotation mark is more reliable, since it forces the parser to treat it as string.
- Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144204
-----------------------------------------------------------
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/#review144204
-----------------------------------------------------------
Fix it, then Ship it!
lgtm, except the online doc versioning.
docs/_config.yml (line 26)
<https://reviews.apache.org/r/50614/#comment210209>
Single quotation marks are mandatory here. Otherwise, the tool we use will parse this as a float number and fail.
Also, we have never publised a 0.x.1 online doc site since 0.8. It should be OK if we just overwrite the current 0.10 online doc site.
- Yi Pan (Data Infrastructure)
On July 29, 2016, 9:04 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50614/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 9:04 p.m.)
>
>
> Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
>
>
> Bugs: SAMZA-987
> https://issues.apache.org/jira/browse/SAMZA-987
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-987 - Preparing for 0.10.1 version release
>
>
> Diffs
> -----
>
> bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
> docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
> docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
> gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
> samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
> samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
> samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
>
> Diff: https://reviews.apache.org/r/50614/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 50614: SAMZA-970 - Problems with integration tests
and SAMZA-987 - Preparing for 0.10.1 version release
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50614/
-----------------------------------------------------------
(Updated July 29, 2016, 9:04 p.m.)
Review request for samza, Jake Maes, Xinyu Liu, and Yi Pan (Data Infrastructure).
Summary (updated)
-----------------
SAMZA-970 - Problems with integration tests and SAMZA-987 - Preparing for 0.10.1 version release
Bugs: SAMZA-987
https://issues.apache.org/jira/browse/SAMZA-987
Repository: samza
Description
-------
SAMZA-987 - Preparing for 0.10.1 version release
Diffs
-----
bin/integration-tests.sh af00b5f41e0f521bcef1cf94779ea67c434db469
docs/_config.yml dc1a66fa743d464c70d92406540fd7122c45272c
docs/startup/hello-samza/versioned/index.md e1ef4da845fdc7ecb42456b834a112986c13a5d5
gradle.properties 16e1f5d43f0415c511689480f8cb67d84e2baadf
samza-test/src/main/python/configs/tests.json 30be820d1f8f27629ab15f853533d558af8b53a5
samza-test/src/main/python/requirements.txt 2ae95908248516b5b26e671f24fa680f7b801675
samza-test/src/main/python/samza_job_yarn_deployer.py 38635ca5899c43fb61d6b4042e8543f0508fd41b
Diff: https://reviews.apache.org/r/50614/diff/
Testing
-------
./bin/check-all.sh
Thanks,
Navina Ramesh