[jira] [Commented] (MCOMPILER-446) Compiler is crashing while setting JPMS module version

["Artem Grankin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCOMPILER-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400319#comment-17400319 ] 

Artem Grankin commented on MCOMPILER-446:
-----------------------------------------

I can confirm there is a bug. On our project we don't follow semver, we simply use part of commit hash to differentiate one version from the other. So there is 6/16 chance version will start with a letter not number and build will fail. Tested with 3.8.0 - there was no such issue there.

> Compiler is crashing while setting JPMS module version
> ------------------------------------------------------
>
>                 Key: MCOMPILER-446
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-446
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>    Affects Versions: 3.8.1
>            Reporter: Bruno Medeiros
>            Priority: Major
>
> I have upgraded maven compiler plugin to 3.8.1 and I started getting this error:
> {code:java}
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project common: Fatal error compiling: error: bad value for --module-version option: 'local-SNAPSHOT' -> [Help 1]{code}
> Because we set versions in pom to local-SNAPHOT (and use maven-version-plugin when we actually realease to set a proper version), all our builds are failing locally.
> It seems javac does not like versions that do not have just alpha characters, like ours local-SNAPHOT.
> I thought about a few ways to fix that:
>  * Allow the use of --module-version to be optional through config
>  * Allow the version itself to be configurable
>  * Validate if the version is a valid version for --module-version and not set it in case it is not
> Let me know what you guys think, I can try to provide a PR with the given solution.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)