You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/12 06:33:35 UTC
[GitHub] [spark] imback82 opened a new pull request #34255: [SPARK-36982] Migrate SHOW TABLES to use V2 command by default
imback82 opened a new pull request #34255:
URL: https://github.com/apache/spark/pull/34255
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to use V2 commands as default as outlined in [SPARK-36588](https://issues.apache.org/jira/browse/SPARK-36588), and this PR migrates `SHOW NAMESPACES` to use v2 command by default. (Technically speaking, there is no v1 command for `SHOW NAMESPACES/DATABASES`, but this PR removes an extra check in `ResolveSessionCatalog` to handle session catalog.)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It's been a while since we introduced the v2 commands, and it seems reasonable to use v2 commands by default even for the session catalog, with a legacy config to fall back to the v1 commands.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, the user can use v1 command by setting `spark.sql.legacy.useV1Command` to `true`.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW TABLES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r726802158
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3364,7 +3364,7 @@ object SQLConf {
buildConf("spark.sql.legacy.keepCommandOutputSchema")
.internal()
.doc("When true, Spark will keep the output schema of commands such as SHOW DATABASES " +
- "unchanged, for v1 catalog and/or table.")
Review comment:
@cloud-fan I am removing the reference to `v1 catalog` since the `KeepLegacyOutputs` rule runs regardless of catalog versions. Let me know if this is incorrect, and I need to update `KeepLegacyOutputs` to run only for session catalog.
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -270,13 +262,7 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
DropDatabaseCommand(db, d.ifExists, d.cascade)
case ShowTables(DatabaseInSessionCatalog(db), pattern, output) if conf.useV1Command =>
- val newOutput = if (conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
Review comment:
This was already handled in `KeepLegacyOutputs`, so I am removing this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r727329947
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -270,13 +262,7 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
DropDatabaseCommand(db, d.ifExists, d.cascade)
case ShowTables(DatabaseInSessionCatalog(db), pattern, output) if conf.useV1Command =>
- val newOutput = if (conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
Review comment:
Yes, `KeepLegacyOutputs` runs before the `Resolution` batch.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandTestUtils.scala
##########
@@ -39,7 +39,9 @@ import org.apache.spark.sql.test.SQLTestUtils
*/
trait DDLCommandTestUtils extends SQLTestUtils {
// The version of the catalog under testing such as "V1", "V2", "Hive V1".
- protected def version: String
+ protected def catalogVersion: String
+ // The version of the SQL command under testing such as "V1", "V2".
+ protected def commandVersion: String
Review comment:
I am separating out `version` into `catalogVersion` and `commandVersion` to have a finer control of the message (for example, we need to have the `Hive V1` version, and there are commands like `SHOW NAMESPACES` with v1 catalog always with v2 command. )
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowNamespacesSuite.scala
##########
@@ -38,15 +38,11 @@ trait ShowNamespacesSuiteBase extends command.ShowNamespacesSuiteBase {
}.getMessage
assert(errMsg.contains("Namespace 'dummy' not found"))
}
-
- test("SPARK-34359: keep the legacy output schema") {
- withSQLConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA.key -> "true") {
- assert(sql("SHOW NAMESPACES").schema.fieldNames.toSeq == Seq("databaseName"))
- }
- }
}
class ShowNamespacesSuite extends ShowNamespacesSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = "V2" // There is only V2 variant of SHOW NAMESPACES.
Review comment:
The test name will be as following now (to be explicit about the command version):
```
SHOW NAMESPACES using V1 catalog V2 command: default namespace (3 seconds, 691 milliseconds)
...
SHOW NAMESPACES using V2 catalog V2 command: default namespace (84 milliseconds)
```
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowNamespacesSuiteBase.scala
##########
@@ -128,4 +128,10 @@ trait ShowNamespacesSuiteBase extends QueryTest with DDLCommandTestUtils {
spark.sessionState.catalogManager.reset()
}
}
+
+ test("SPARK-34359: keep the legacy output schema") {
Review comment:
This test can be now run with v2 catalog, thus moved to a common place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r727504414
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLCommandTestUtils.scala
##########
@@ -39,7 +39,9 @@ import org.apache.spark.sql.test.SQLTestUtils
*/
trait DDLCommandTestUtils extends SQLTestUtils {
// The version of the catalog under testing such as "V1", "V2", "Hive V1".
- protected def version: String
+ protected def catalogVersion: String
+ // The version of the SQL command under testing such as "V1", "V2".
+ protected def commandVersion: String
Review comment:
I am separating out `version` into `catalogVersion` and `commandVersion` to have a finer control of the message (for example, we need to have the `Hive V1` version, and there are commands like `SHOW NAMESPACES` with v1 catalog always with v2 command. )
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowNamespacesSuite.scala
##########
@@ -38,15 +38,11 @@ trait ShowNamespacesSuiteBase extends command.ShowNamespacesSuiteBase {
}.getMessage
assert(errMsg.contains("Namespace 'dummy' not found"))
}
-
- test("SPARK-34359: keep the legacy output schema") {
- withSQLConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA.key -> "true") {
- assert(sql("SHOW NAMESPACES").schema.fieldNames.toSeq == Seq("databaseName"))
- }
- }
}
class ShowNamespacesSuite extends ShowNamespacesSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = "V2" // There is only V2 variant of SHOW NAMESPACES.
Review comment:
The test name will be as following now (to be explicit about the command version):
```
SHOW NAMESPACES using V1 catalog V2 command: default namespace (3 seconds, 691 milliseconds)
...
SHOW NAMESPACES using V2 catalog V2 command: default namespace (84 milliseconds)
```
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowNamespacesSuiteBase.scala
##########
@@ -128,4 +128,10 @@ trait ShowNamespacesSuiteBase extends QueryTest with DDLCommandTestUtils {
spark.sessionState.catalogManager.reset()
}
}
+
+ test("SPARK-34359: keep the legacy output schema") {
Review comment:
This test can be now run with v2 catalog, thus moved to a common place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r727329947
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -270,13 +262,7 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
DropDatabaseCommand(db, d.ifExists, d.cascade)
case ShowTables(DatabaseInSessionCatalog(db), pattern, output) if conf.useV1Command =>
- val newOutput = if (conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
Review comment:
Yes, `KeepLegacyOutputs` runs before the `Resolution` batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940729119
**[Test build #144130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144130/testReport)** for PR 34255 at commit [`5ef769c`](https://github.com/apache/spark/commit/5ef769c36b3446d7e356fffa75128fff52956d16).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34255:
URL: https://github.com/apache/spark/pull/34255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r726837054
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala
##########
@@ -35,26 +32,6 @@ import org.apache.spark.sql.internal.SQLConf
*/
trait ShowTablesSuiteBase extends command.ShowTablesSuiteBase {
Review comment:
shall we extend `TestsV1AndV2Commands` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r728110756
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowNamespacesSuite.scala
##########
@@ -27,6 +27,8 @@ import org.apache.spark.sql.internal.SQLConf
* The class contains tests for the `SHOW NAMESPACES` command to check V2 table catalogs.
*/
class ShowNamespacesSuite extends command.ShowNamespacesSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = "V2" // There is only V2 variant of SHOW NAMESPACES.
Review comment:
This overrides nothing. The default impl in `CommandSuiteBase` is already `V2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942538219
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942449843
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940954039
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144130/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940817173
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48607/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940729119
**[Test build #144130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144130/testReport)** for PR 34255 at commit [`5ef769c`](https://github.com/apache/spark/commit/5ef769c36b3446d7e356fffa75128fff52956d16).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942684270
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144205/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942491673
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941729510
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48644/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941564819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941729510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941564819
**[Test build #144166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144166/testReport)** for PR 34255 at commit [`9c24d07`](https://github.com/apache/spark/commit/9c24d07d2e0171a96f7cee17c38b3628b5c86872).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941729510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941564819
**[Test build #144166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144166/testReport)** for PR 34255 at commit [`9c24d07`](https://github.com/apache/spark/commit/9c24d07d2e0171a96f7cee17c38b3628b5c86872).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942679822
**[Test build #144205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144205/testReport)** for PR 34255 at commit [`de4dc66`](https://github.com/apache/spark/commit/de4dc665d2c6c14a4c14ed6d5f6fa3ecd42c1dfe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942407807
**[Test build #144205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144205/testReport)** for PR 34255 at commit [`de4dc66`](https://github.com/apache/spark/commit/de4dc665d2c6c14a4c14ed6d5f6fa3ecd42c1dfe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941729510
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48644/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942407807
**[Test build #144205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144205/testReport)** for PR 34255 at commit [`de4dc66`](https://github.com/apache/spark/commit/de4dc665d2c6c14a4c14ed6d5f6fa3ecd42c1dfe).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940801519
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48607/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r726832692
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -270,13 +262,7 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
DropDatabaseCommand(db, d.ifExists, d.cascade)
case ShowTables(DatabaseInSessionCatalog(db), pattern, output) if conf.useV1Command =>
- val newOutput = if (conf.getConf(SQLConf.LEGACY_KEEP_COMMAND_OUTPUT_SCHEMA)) {
Review comment:
is this because `ResolveSessionCatalog` always runs after `KeepLegacyOutputs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941564819
**[Test build #144166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144166/testReport)** for PR 34255 at commit [`9c24d07`](https://github.com/apache/spark/commit/9c24d07d2e0171a96f7cee17c38b3628b5c86872).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r728110756
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowNamespacesSuite.scala
##########
@@ -27,6 +27,8 @@ import org.apache.spark.sql.internal.SQLConf
* The class contains tests for the `SHOW NAMESPACES` command to check V2 table catalogs.
*/
class ShowNamespacesSuite extends command.ShowNamespacesSuiteBase with CommandSuiteBase {
+ override def commandVersion: String = "V2" // There is only V2 variant of SHOW NAMESPACES.
Review comment:
This overrides nothing. The default impl in `CommandSuiteBase` is already `V2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941630708
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48644/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r726834714
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/CommandSuiteBase.scala
##########
@@ -48,3 +53,29 @@ trait CommandSuiteBase extends SharedSparkSession {
assert(location.endsWith(expected))
}
}
+
+/**
+ * The trait that enables running a test for both v1 and v2 command.
+ */
+trait TestsV1AndV2Commands extends DDLCommandTestUtils {
Review comment:
shall we put it in the package `org.apache.spark.sql.execution.command`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940764696
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48607/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW TABLES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r726802158
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3364,7 +3364,7 @@ object SQLConf {
buildConf("spark.sql.legacy.keepCommandOutputSchema")
.internal()
.doc("When true, Spark will keep the output schema of commands such as SHOW DATABASES " +
- "unchanged, for v1 catalog and/or table.")
Review comment:
@cloud-fan I am removing the reference to `v1 catalog` since the `KeepLegacyOutputs` rule runs regardless of catalog versions. Let me know if this is incorrect; I need to update `KeepLegacyOutputs` to run only for session catalog in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941720090
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48644/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942538219
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48684/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942684270
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144205/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941842904
**[Test build #144166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144166/testReport)** for PR 34255 at commit [`9c24d07`](https://github.com/apache/spark/commit/9c24d07d2e0171a96f7cee17c38b3628b5c86872).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940952216
**[Test build #144130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144130/testReport)** for PR 34255 at commit [`5ef769c`](https://github.com/apache/spark/commit/5ef769c36b3446d7e356fffa75128fff52956d16).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-942635027
+1, LGTM. Merging to master.
Thank you, @imback82 and @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941847023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-941847023
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144166/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #34255:
URL: https://github.com/apache/spark/pull/34255#discussion_r726835105
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowNamespacesSuite.scala
##########
@@ -46,7 +46,10 @@ trait ShowNamespacesSuiteBase extends command.ShowNamespacesSuiteBase {
}
}
-class ShowNamespacesSuite extends ShowNamespacesSuiteBase with CommandSuiteBase {
+class ShowNamespacesSuite extends ShowNamespacesSuiteBase
+ with CommandSuiteBase with TestsV1AndV2Commands {
Review comment:
there is no v1 SHOW NAMESPACE command, do we really need to run tests twice here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940954039
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144130/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34255: [SPARK-36982] Migrate SHOW NAMESPACES to use V2 command by default
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34255:
URL: https://github.com/apache/spark/pull/34255#issuecomment-940817173
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48607/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org