You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/08 17:38:03 UTC

[GitHub] [hbase] saintstack edited a comment on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…

saintstack edited a comment on pull request #1664:
URL: https://github.com/apache/hbase/pull/1664#issuecomment-625883657


   These PRs run with  -Phadoop-3.0, not -Dhadoop.profile=3.0 (see console log). They run w/ config that is not the same as nightly (an issue Nick has been talking up). The REST issue is because of doubled up profile -- hadoop3 and hadoop2 are both active.
   
   I tried  the patch locally. All REST tests pass for me w/ jdk11 using hadoop.profile=3.0.
   
   I think you should just go ahead and commit.
   
   But, just had a thought, if you commit, will we fail all PRs from here on out until we change the PR builds to do -Dhadoop.version when branch-2?
   
   PR builds should be failing now because if I build locally w/ -Phadoop-3.0 on branch-2, that fails. Maybe we don't run the REST tests usually.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org