You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/27 03:43:35 UTC
[GitHub] [doris] Yulei-Yang opened a new issue, #13717: [Enhancement] improve error message for literal type overlength when insert
Yulei-Yang opened a new issue, #13717:
URL: https://github.com/apache/doris/issues/13717
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues.
### Description
when insert a literal value whose length is longer than schema definition, the error message always cause misunderstanding. because it use preceding 10 chars instead of whole string, and says it's the whole string.
CREATE TABLE `insert_length_test` (
`id` int(11) NOT NULL COMMENT '',
`name` varchar(10) NOT NULL COMMENT ''
) ENGINE=OLAP
UNIQUE KEY(`id`)
COMMENT "OLAP"
DISTRIBUTED BY HASH(`id`) BUCKETS 8
PROPERTIES (
"storage_format" = "V2"
);
insert into insert_length_test (id, name) values (1, "0123456789abcd");
curl http://172.17.0.2:8040/api/_load_error_log?file=__shard_0/error_log_insert_stmt_aba9d04457664ddd-912b9dd92ef38758_aba9d04457664ddd_912b9dd92ef38758
Reason: the length of input is too long than schema. column_name: name; input str: [0123456789] schema length: 10; actual length: 14; . src line [];
"0123456789" is not the whole string, but this log make user think it as a whole string. while it is not overlength, in this case, it is misleading。
### Solution
change error message "input str" to "first 32 bytes of input str", and log preceding 32 chars to help user find the exception row.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on issue #13717: [Enhancement] improve error message for literal type overlength when insert
Posted by GitBox <gi...@apache.org>.
Yulei-Yang commented on issue #13717:
URL: https://github.com/apache/doris/issues/13717#issuecomment-1300713558
already been merged to master branch, close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yulei-Yang closed issue #13717: [Enhancement] improve error message for literal type overlength when insert
Posted by GitBox <gi...@apache.org>.
Yulei-Yang closed issue #13717: [Enhancement] improve error message for literal type overlength when insert
URL: https://github.com/apache/doris/issues/13717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on issue #13717: [Enhancement] improve error message for literal type overlength when insert
Posted by GitBox <gi...@apache.org>.
Yulei-Yang commented on issue #13717:
URL: https://github.com/apache/doris/issues/13717#issuecomment-1292932815
please review this pr: https://github.com/apache/doris/pull/13718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org