You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "vmamidi (via GitHub)" <gi...@apache.org> on 2023/01/30 21:03:34 UTC
[GitHub] [trafficserver] vmamidi opened a new pull request, #9338: Revert PRs 7667 and 7807
vmamidi opened a new pull request, #9338:
URL: https://github.com/apache/trafficserver/pull/9338
PR 7807 could leave the HTTP State machine in a INACTIVE state.
For example, if state_cache_open_read is rescheduled in an error using the below code.
```
case CACHE_EVENT_OPEN_READ_FAILED:
if ((intptr_t)data == -ECACHE_DOC_BUSY) {
// Somebody else is writing the object
if (open_read_tries <= master_sm->t_state.txn_conf->max_cache_open_read_retries) {
// Retry to read; maybe the update finishes in time
open_read_cb = false;
do_schedule_in();
} else {
```
This code will return to event system leaving the state machine in a INACTIVE state and results in an abort.
```
if (captive_action.cancelled == 1) {
return VC_EVENT_CONT; // SM gave up on us
}
```
This can be easily reproduced by setting proxy.config.http.number_of_redirections greater than zero.(https://docs.trafficserver.apache.org/en/8.1.x/admin-guide/files/records.config.en.html#proxy-config-http-number-of-redirections)
Although I like the idea behind 7667, I am proposing reverting 7667 along with 7807 as there were concerns about the crashes with 7667. I am yet to look at PRs #8423 and #8443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #9338: Revert PRs 7667 and 7807
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #9338:
URL: https://github.com/apache/trafficserver/pull/9338#issuecomment-1554936967
[approve ci centos cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] commented on pull request #9338: Revert PRs 7667 and 7807
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9338:
URL: https://github.com/apache/trafficserver/pull/9338#issuecomment-1683214347
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9338: Revert PRs 7667 and 7807
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9338:
URL: https://github.com/apache/trafficserver/pull/9338#issuecomment-1414149876
Talking to Bryan and VJ, we'll hold off on this until we have more testing, and reviews. But this is a showstopper for a 10.0.0 release. We will revert this for 9.2.x though which will go out into v9.2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] github-actions[bot] closed pull request #9338: Revert PRs 7667 and 7807
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9338: Revert PRs 7667 and 7807
URL: https://github.com/apache/trafficserver/pull/9338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #9338: Revert PRs 7667 and 7807
Posted by "shinrich (via GitHub)" <gi...@apache.org>.
shinrich commented on PR #9338:
URL: https://github.com/apache/trafficserver/pull/9338#issuecomment-1492497760
We applied these changes to fix asserts before h2 to origin as well. Perhaps those asserts were only seen in the Yahoo environment? Perhaps we should push forward and fix the issue with the stalled/inactive HttpSMs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9338: Revert PRs 7667 and 7807
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9338:
URL: https://github.com/apache/trafficserver/pull/9338#issuecomment-1409361829
(Modified the description to link issues mentioned)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] vmamidi commented on pull request #9338: Revert PRs 7667 and 7807
Posted by "vmamidi (via GitHub)" <gi...@apache.org>.
vmamidi commented on PR #9338:
URL: https://github.com/apache/trafficserver/pull/9338#issuecomment-1410492428
We can leave PRs #8423 and #8443 in the code for future use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org