You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/16 20:53:44 UTC

[GitHub] [accumulo] ben-manes commented on a diff in pull request #2709: Replaced HashMap in ZooCacheFactory with bounded-size Cache

ben-manes commented on code in PR #2709:
URL: https://github.com/apache/accumulo/pull/2709#discussion_r874148111


##########
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCacheFactory.java:
##########
@@ -119,7 +118,8 @@ public ZooCache getNewZooCache(String zooKeepers, int sessionTimeout) {
    */
   void reset() {
     synchronized (instances) {
-      instances.clear();
+      instances.invalidateAll();
+      instances.cleanUp();

Review Comment:
   fyi, `cleanUp` is implicit if clearing the cache so this is not needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org