You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "suyanhanx (via GitHub)" <gi...@apache.org> on 2023/05/06 11:40:28 UTC

[GitHub] [incubator-opendal] suyanhanx opened a new pull request, #2215: feat(core): check capability

suyanhanx opened a new pull request, #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215

   close #2060
   
   Tasks: 
   - [ ] azdfs
   - [ ] dashmap
   - [ ] fs
   - [ ] ftp
   - [ ] gcs
   - [ ] ghac
   - [ ] hdfs
   - [ ] http
   - [ ] ipfs
   - [ ] ipmfs
   - [ ] memcached
   - [ ] memory
   - [ ] moka
   - [ ] obs
   - [ ] oss
   - [ ] redis
   - [ ] rocksdb
   - [ ] s3
   - [ ] sled
   - [ ] wasabi
   - [ ] webdav
   - [ ] webhdfs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] suyanhanx commented on pull request #2215: feat(core): check capability

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215#issuecomment-1537137595

   @Xuanwo We may be able to split the test files afterward. Because the capability grouping becomes more.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] suyanhanx commented on pull request #2215: feat(core): check capability

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215#issuecomment-1537157266

   > > We may be able to split the test files afterward. Because the capability grouping becomes more.
   > 
   > We will refactor them all some day so that we don't need to write `if can_xxx` by hand anymore. And the layout will be re-org until them.
   
   Looking forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2215: feat(core): check capability

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215#issuecomment-1537156525

   > We may be able to split the test files afterward. Because the capability grouping becomes more.
   
   We will refactor them all some day so that we don't need to write `if can_xxx` by hand anymore. And the layout will be re-org until them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo merged pull request #2215: feat(core): check capability

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2215: feat(core): check capability

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215#issuecomment-1537498266

   Hi, @suyanhanx, Is this PR ready for review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] suyanhanx commented on pull request #2215: feat(core): check capability

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on PR #2215:
URL: https://github.com/apache/incubator-opendal/pull/2215#issuecomment-1537556631

   > Hi, @suyanhanx, Is this PR ready for review?
   
   It will be ready today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org