You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/11/26 15:04:40 UTC

Review Request 40750: Add GC tuning params to Collector daemon similar to HBase

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40750/
-----------------------------------------------------------

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-14088
    https://issues.apache.org/jira/browse/AMBARI-14088


Repository: ambari


Description
-------

Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector.

Error trace:

javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms.
        at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3fc5212 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 

Diff: https://reviews.apache.org/r/40750/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 40750: Add GC tuning params to Collector daemon similar to HBase

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40750/#review108382
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Nov. 30, 2015, 7:48 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40750/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 7:48 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-14088
>     https://issues.apache.org/jira/browse/AMBARI-14088
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector.
> 
> Error trace:
> 
> javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms.
>         at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3b61fa1 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 7cd835e 
> 
> Diff: https://reviews.apache.org/r/40750/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 40750: Add GC tuning params to Collector daemon similar to HBase

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40750/
-----------------------------------------------------------

(Updated Ноя. 30, 2015, 7:48 п.п.)


Review request for Ambari and Sid Wagle.


Bugs: AMBARI-14088
    https://issues.apache.org/jira/browse/AMBARI-14088


Repository: ambari


Description
-------

Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector.

Error trace:

javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms.
        at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3b61fa1 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 7cd835e 

Diff: https://reviews.apache.org/r/40750/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 40750: Add GC tuning params to Collector daemon similar to HBase

Posted by Sid Wagle <sw...@hortonworks.com>.

> On Nov. 30, 2015, 5:11 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java, line 1155
> > <https://reviews.apache.org/r/40750/diff/2/?file=1147490#file1147490line1155>
> >
> >     Can we add some log retention setting to avoid too much gc log from being retained.

Also, does Occupancy ratio make sense for collector?


- Sid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40750/#review108329
-----------------------------------------------------------


On Nov. 26, 2015, 2:08 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40750/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 2:08 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-14088
>     https://issues.apache.org/jira/browse/AMBARI-14088
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector.
> 
> Error trace:
> 
> javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms.
>         at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3fc5212 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 5e7335a 
> 
> Diff: https://reviews.apache.org/r/40750/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 40750: Add GC tuning params to Collector daemon similar to HBase

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40750/#review108329
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java (line 1155)
<https://reviews.apache.org/r/40750/#comment167761>

    Can we add some log retention setting to avoid too much gc log from being retained.


- Sid Wagle


On Nov. 26, 2015, 2:08 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40750/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 2:08 p.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-14088
>     https://issues.apache.org/jira/browse/AMBARI-14088
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector.
> 
> Error trace:
> 
> javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms.
>         at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3fc5212 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 5e7335a 
> 
> Diff: https://reviews.apache.org/r/40750/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 40750: Add GC tuning params to Collector daemon similar to HBase

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40750/
-----------------------------------------------------------

(Updated Ноя. 26, 2015, 2:08 п.п.)


Review request for Ambari and Sid Wagle.


Bugs: AMBARI-14088
    https://issues.apache.org/jira/browse/AMBARI-14088


Repository: ambari


Description
-------

Presently we resort to all defaults. We can optimize this much better by doing some memory profiling on the collector.

Error trace:

javax.ws.rs.WebApplicationException: org.apache.phoenix.exception.PhoenixIOException: org.apache.phoenix.exception.PhoenixIOException: org.apache.hadoop.hbase.DoNotRetryIOException: METRIC_RECORD,,1447979747302.84e03f0ea4ac1ba9d0dde2ce14d0c878.: Requested memory of 31743360 bytes could not be allocated from remaining memory of 69028112 bytes from global pool of 96642662 bytes after waiting for 10000ms.
        at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:84)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog213.java 3fc5212 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml 3335c90 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog213Test.java 5e7335a 

Diff: https://reviews.apache.org/r/40750/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen