svn commit: r739616 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java

[iv...@apache.org]

Author: ivaynberg
Date: Sat Jan 31 21:09:58 2009
New Revision: 739616

URL: http://svn.apache.org/viewvc?rev=739616&view=rev
Log:
WICKET-2041: cleaned up

Modified:
    wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java

Modified: wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java?rev=739616&r1=739615&r2=739616&view=diff
==============================================================================
--- wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java (original)
+++ wicket/branches/wicket-1.3.x/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/convert/ConverterLocator.java Sat Jan 31 21:09:58 2009
@@ -110,24 +110,17 @@
 				return "";
 			}
 
-			final Object converted = Objects.convertValue(value, String.class);
-			if (converted == null)
+			try
 			{
-				// object was converted to null
-				return "";
-			}
-			else if (converted instanceof String)
-			{
-				// object was successfully converted to a string
-				return (String)converted;
+				return (String)Objects.convertValue(value, String.class);
 			}
-			else
+			catch (Exception e)
 			{
-				// object could not be converted to a string, hardcast to string
 				throw new ConversionException("Could not convert object of type: " +
 					value.getClass() + " to string. Possible its #toString() returned null. " +
 					"Either install a custom converter (see IConverterLocator) or " +
-					"override #toString() to return a non-null value.");
+					"override #toString() to return a non-null value.").setSourceValue(value)
+					.setConverter(this);
 			}
 		}
 	}