You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/10 03:41:10 UTC
[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #164:
HDDS-426. Add field modificationTime for Volume and Bucket
cxorm commented on a change in pull request #164: HDDS-426. Add field modificationTime for Volume and Bucket
URL: https://github.com/apache/hadoop-ozone/pull/164#discussion_r396450260
##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
##########
@@ -155,16 +161,19 @@ public OzoneBucket(Configuration conf, ClientProtocol proxy,
* @param storageType StorageType of the bucket.
* @param versioning versioning status of the bucket.
* @param creationTime creation time of the bucket.
+ * @param modificationTime modification time of the bucket.
*/
@SuppressWarnings("parameternumber")
public OzoneBucket(Configuration conf, ClientProtocol proxy,
Review comment:
Thanks @xiaoyuyao for the review.
Do you mean that we should have a new API such as
```
public OzoneBucket(Configuration conf, ClientProtocol proxy,
String volumeName, String bucketName, StorageType storageType,
Boolean versioning, long creationTime, long modificationTime,
Map<String, String> metadata) {
this.modificationTime = modificationTime;
OzoneBucket(conf, proxy, volumeName, bucketName, storageType, versioning,
creationTime, metadata); // existed API.
}
```
here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org