You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mr...@apache.org on 2026/09/26 18:32:37 UTC

(ofbiz-framework) branch trunk updated: Fixed: Regression in the minilang-to-Groovy conversion of InventoryIssueServices.groovy (OFBIZ-13614)

This is an automated email from the ASF dual-hosted git repository.

mridulpathak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new f778f1fbc6 Fixed: Regression in the minilang-to-Groovy conversion of InventoryIssueServices.groovy (OFBIZ-13614)
f778f1fbc6 is described below

commit f778f1fbc6c7b400f9a8d43034ae49ed3f1bf354
Author: Mridul Pathak <mr...@gmail.com>
AuthorDate: Sat Sep 26 18:28:15 2026 +0530

    Fixed: Regression in the minilang-to-Groovy conversion of InventoryIssueServices.groovy (OFBIZ-13614)
    
    issueImmediatelyFulfilledOrderItem() no longer throws on a nonexistent order/item combination, matching the original mini-lang which evaluated to false gracefully on a null base object and returned a clean success no-op instead of aborting.
---
 .../ofbiz/product/product/inventory/InventoryIssueServices.groovy       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy b/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
index c5fd14793e..7a2b8b22ac 100644
--- a/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
+++ b/applications/product/src/main/groovy/org/apache/ofbiz/product/product/inventory/InventoryIssueServices.groovy
@@ -71,7 +71,7 @@ Map issueImmediatelyFulfilledOrderItem() {
 
     // kind of like the inventory reservation routine (with a few variations...), find InventoryItems to issue from,
     // but instead of doing the reservation just create an issuance and an inventory item detail for the change
-    if (orderItem.productId) {
+    if (orderItem?.productId) {
         // NOTE: the inventory will be issued from the OrderHeader.originFacilityId
         GenericValue orderHeader = parameters.orderHeader ?:
                 from('OrderHeader').where(parameters).queryOne()