[GitHub] [incubator-superset] mistercrunch opened a new pull request #7350: Refactor out controlUtils.js module + unit tests

[GitBox <gi...@apache.org>]

mistercrunch opened a new pull request #7350: Refactor out controlUtils.js module + unit tests
URL: https://github.com/apache/incubator-superset/pull/7350
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Controls are a breed of complex overrides, mutations and a patchwork of twisted logic. This effort breaks down large functions into smaller ones, make things DRYer, and add a covering set of tests. The refactor is a bit risky, but much less risky than having the current logic in place.
   
   I got pulled in this rabbit hole while trying to debug an issue around the "Polygon" example, where it would fail when missing the metric (related to color scaler and bounds). I then realized that the validator overrides weren't applied when using `setControlValue`, post load. So I started digging into this patchwork in `store.js` the really evolved to be messy over time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org