You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/09/23 08:40:49 UTC
Review Request 38666: LENS-772 : Fix time and size based rolling for
logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-772
https://issues.apache.org/jira/browse/LENS-772
Repository: lens
Description
-------
Updated logback.xml
Diffs
-----
tools/conf/client/logback.xml d142348
tools/conf/server/logback.xml c27bea2
Diff: https://reviews.apache.org/r/38666/diff/
Testing
-------
Verified rolling is fine with the changes.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100178
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On Sept. 23, 2015, 9:02 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 9:02 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated logback.xml
>
>
> Diffs
> -----
>
> tools/conf-pseudo-distr/client/logback.xml d142348
> tools/conf-pseudo-distr/server/logback.xml c27bea2
> tools/conf/client/logback.xml d142348
> tools/conf/server/logback.xml c27bea2
>
> Diff: https://reviews.apache.org/r/38666/diff/
>
>
> Testing
> -------
>
> Verified rolling is fine with the changes.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 23, 2015, 9:28 a.m., Raju Bairishetti wrote:
> > tools/conf-pseudo-distr/server/logback.xml, line 103
> > <https://reviews.apache.org/r/38666/diff/2/?file=1083082#file1083082line103>
> >
> > Wy we are not using timeBasedFileNamingAndTriggeringPolicy here?
Stats logs are rolled one file per hour and uploaded. Simple TimeBasedRollingPolicy will do here.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100179
-----------------------------------------------------------
On Sept. 23, 2015, 9:02 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 9:02 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated logback.xml
>
>
> Diffs
> -----
>
> tools/conf-pseudo-distr/client/logback.xml d142348
> tools/conf-pseudo-distr/server/logback.xml c27bea2
> tools/conf/client/logback.xml d142348
> tools/conf/server/logback.xml c27bea2
>
> Diff: https://reviews.apache.org/r/38666/diff/
>
>
> Testing
> -------
>
> Verified rolling is fine with the changes.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100179
-----------------------------------------------------------
tools/conf-pseudo-distr/server/logback.xml (line 92)
<https://reviews.apache.org/r/38666/#comment157340>
Wy we are not using timeBasedFileNamingAndTriggeringPolicy here?
- Raju Bairishetti
On Sept. 23, 2015, 9:02 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 9:02 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated logback.xml
>
>
> Diffs
> -----
>
> tools/conf-pseudo-distr/client/logback.xml d142348
> tools/conf-pseudo-distr/server/logback.xml c27bea2
> tools/conf/client/logback.xml d142348
> tools/conf/server/logback.xml c27bea2
>
> Diff: https://reviews.apache.org/r/38666/diff/
>
>
> Testing
> -------
>
> Verified rolling is fine with the changes.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/
-----------------------------------------------------------
(Updated Sept. 23, 2015, 9:02 a.m.)
Review request for lens.
Bugs: LENS-772
https://issues.apache.org/jira/browse/LENS-772
Repository: lens
Description
-------
Updated logback.xml
Diffs (updated)
-----
tools/conf-pseudo-distr/client/logback.xml d142348
tools/conf-pseudo-distr/server/logback.xml c27bea2
tools/conf/client/logback.xml d142348
tools/conf/server/logback.xml c27bea2
Diff: https://reviews.apache.org/r/38666/diff/
Testing
-------
Verified rolling is fine with the changes.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100156
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Sept. 23, 2015, 12:10 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 12:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated logback.xml
>
>
> Diffs
> -----
>
> tools/conf/client/logback.xml d142348
> tools/conf/server/logback.xml c27bea2
>
> Diff: https://reviews.apache.org/r/38666/diff/
>
>
> Testing
> -------
>
> Verified rolling is fine with the changes.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Sept. 23, 2015, 7:16 a.m., Raju Bairishetti wrote:
> > Can you make changes in **conf-pseudo-distr** as well?
Done!
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100161
-----------------------------------------------------------
On Sept. 23, 2015, 9:02 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 9:02 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated logback.xml
>
>
> Diffs
> -----
>
> tools/conf-pseudo-distr/client/logback.xml d142348
> tools/conf-pseudo-distr/server/logback.xml c27bea2
> tools/conf/client/logback.xml d142348
> tools/conf/server/logback.xml c27bea2
>
> Diff: https://reviews.apache.org/r/38666/diff/
>
>
> Testing
> -------
>
> Verified rolling is fine with the changes.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 38666: LENS-772 : Fix time and size based rolling
for logs
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38666/#review100161
-----------------------------------------------------------
Can you make changes in **conf-pseudo-distr** as well?
- Raju Bairishetti
On Sept. 23, 2015, 6:40 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38666/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2015, 6:40 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-772
> https://issues.apache.org/jira/browse/LENS-772
>
>
> Repository: lens
>
>
> Description
> -------
>
> Updated logback.xml
>
>
> Diffs
> -----
>
> tools/conf/client/logback.xml d142348
> tools/conf/server/logback.xml c27bea2
>
> Diff: https://reviews.apache.org/r/38666/diff/
>
>
> Testing
> -------
>
> Verified rolling is fine with the changes.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>