You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/07/11 16:59:50 UTC
[PR] perf: optimize spark_log in datafusion-comet-spark-expr [datafusion-comet]
andygrove opened a new pull request, #4896:
URL: https://github.com/apache/datafusion-comet/pull/4896
> This PR was created by an LLM as a draft PR. I will mark it as ready for review after human review.
## Which issue does this PR close?
N/A — autonomous exploratory PR.
## Rationale for this change
Hoist the constant operand's ln() out of the per-element loop in the scalar-base and scalar-value paths, removing one transcendental ln() call per row while preserving exact null/NaN semantics.
## What changes are included in this PR?
Hoist the constant operand's ln() out of the per-element loop in the scalar-base and scalar-value paths, removing one transcendental ln() call per row while preserving exact null/NaN semantics.
## How are these changes tested?
Correctness: unit tests + seeded differential fuzz (bit-identical Arrow output vs `main`).
Benchmark (criterion):
- spark_log_ array base, scalar value: 29.349% faster (base 48865ns -> cand 34524ns)
- spark_log_ scalar base, array value: 29.341% faster (base 48927ns -> cand 34571ns)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] perf: optimize spark_log in datafusion-comet-spark-expr [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed pull request #4896: perf: optimize spark_log in datafusion-comet-spark-expr
URL: https://github.com/apache/datafusion-comet/pull/4896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org