You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by rohannr <gi...@git.apache.org> on 2016/04/22 01:13:49 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...
GitHub user rohannr opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/849
ZEPPELIN-818: Set appropriate default permissions and allow user to c…
### What is this PR for?
This PR makes users who set only r/w permissions the effective owners of the note.
1. If you set readers, and writers and owners is empty, it is automatically set to the user requesting the change.
2. If you set writers, and owners is empty, it is set it to the user requesting the change.
It also fixes a bug that did not allow one to clear the permissions for a note.
### What type of PR is it?
Bug Fix, Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-818
### How should this be tested?
Outline the steps to test the PR here.
### Questions:
* Does this needs documentation? YES
…lear permissions
This change makes users who set permissions the effective owners of the note.
1. If you set readers, and writers and owners is empty, it is automatically set to the user requesting the change.
2. If you set writers, and owners is empty, it is set it to the user requesting the change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rohannr/incubator-zeppelin rohanr/ZEPPELIN-818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/849.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #849
----
commit 083070d26ddd6532f955f4f3d37466553da7fc59
Author: Rohan Ramakrishna <ro...@twitter.com>
Date: 2016-04-21T22:36:17Z
ZEPPELIN-818: Set appropriate default permissions and allow user to clear permissions
This change makes users who set permissions the effective owners of the note.
1. If you set readers, and writers and owners is empty, it is automatically set to the user requesting the change.
2. If you set writers, and owners is empty, it is set it to the user requesting the change.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-214060532
Looks good. Thanks @rohannr for good improvement.
Could you create new JIRA issue as @felixcheung suggested and rebase to resolve conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-825: Set appropriate def...
Posted by rohannr <gi...@git.apache.org>.
Github user rohannr commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-214877302
Created a new JIRA (ZEPPELIN-825) and resolved conflict. Change is ready to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-213656654
Should this be a different JIRA then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-825: Set appropriate def...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-215447199
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-213174433
There is another PR on this same bug?
https://github.com/apache/incubator-zeppelin/pull/846
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-825: Set appropriate def...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/849
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-818: Set appropriate def...
Posted by rohannr <gi...@git.apache.org>.
Github user rohannr commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-213178753
correct, I was in the process of submitting a fix to the JIRA that I filed when that got submitted. This PR also addresses the issue of default owner/writer permissions when they are not set and includes unit tests for both issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-825: Set appropriate def...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/849#issuecomment-214972953
Thanks @rohannr for the improvement and test. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---