You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/10/11 06:32:47 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…
danny0405 opened a new pull request, #6918:
URL: https://github.com/apache/hudi/pull/6918
…uet and log files
Before this patch, for timestamp type, we use LongWrapper for parquet and TimestampMicrosWrapper for avro log, they may keep different precision val here, for example, with timestamp(3), LongWrapper keeps the val as a millisecond long from EPOCH instant, while TimestampMicrosWrapper keeps the val as micro-seconds.
For spark, there is no ambiguity because it uses micro-seconds internally for timestamp type value, while flink uses the TimestampData internally, we better keeps the same precision for better compatibility here.
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6918:
URL: https://github.com/apache/hudi/pull/6918#issuecomment-1274550008
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44cf55e646e8014b975ec86819fc292443692584",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12124",
"triggerID" : "44cf55e646e8014b975ec86819fc292443692584",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44cf55e646e8014b975ec86819fc292443692584 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12124)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6918:
URL: https://github.com/apache/hudi/pull/6918#issuecomment-1274156782
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44cf55e646e8014b975ec86819fc292443692584",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44cf55e646e8014b975ec86819fc292443692584",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44cf55e646e8014b975ec86819fc292443692584 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #6918:
URL: https://github.com/apache/hudi/pull/6918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6918:
URL: https://github.com/apache/hudi/pull/6918#issuecomment-1274224630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44cf55e646e8014b975ec86819fc292443692584",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12124",
"triggerID" : "44cf55e646e8014b975ec86819fc292443692584",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44cf55e646e8014b975ec86819fc292443692584 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12124)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #6918: [HUDI-5006] Use the same wrapper for timestamp type metadata for parq…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6918:
URL: https://github.com/apache/hudi/pull/6918#discussion_r991866611
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -144,7 +144,7 @@ class ColumnStats {
GenericRecord genericRecord = (GenericRecord) record;
- final Object fieldVal = convertValueForSpecificDataTypes(field.schema(), genericRecord.get(field.name()), true);
+ final Object fieldVal = convertValueForSpecificDataTypes(field.schema(), genericRecord.get(field.name()), false);
Review Comment:
Hi, @alexeykudinkin , can you take a look at this line, the change expects to work correctly right ? (same with parquet files, the parquet max/min for timestamp is the raw long, and we use a `LongWrapper` here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org