You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/12/31 09:21:54 UTC

[GitHub] [fineract] ptuomola commented on pull request #1984: FINERACT-1431:PassportDropDown-in-ClientIdentifier

ptuomola commented on pull request #1984:
URL: https://github.com/apache/fineract/pull/1984#issuecomment-1003320098


   Two comments from my side:
   
   1. If the column documentTypeValue is meant to capture the issuing country for the document (which actually can make sense for all kinds of documents, not just passports), would it not make sense to call it that? So how about calling the column e.g. document_issue_country_id rather than document_type_value? Value seems to suggest it's the counterpart for the document_type_id, which is not the case...
   
   2. Why do we need to create a new table for country codes? Can't we just treat it just like any other code value and use the existing code value infrastructure...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org