You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by jo...@apache.org on 2003/07/05 06:27:28 UTC
cvs commit: cocoon-2.1/src/blocks/proxy/java/org/apache/cocoon/generation HttpProxyGenerator.java
joerg 2003/07/04 21:27:27
Modified: src/blocks/proxy/java/org/apache/cocoon/generation
HttpProxyGenerator.java
Log:
TODO added: is the work around still needed after update of commons-httpclient?
Can somebody test this class with the new httpclient? It's used nowhere!
Revision Changes Path
1.3 +7 -3 cocoon-2.1/src/blocks/proxy/java/org/apache/cocoon/generation/HttpProxyGenerator.java
Index: HttpProxyGenerator.java
===================================================================
RCS file: /home/cvs/cocoon-2.1/src/blocks/proxy/java/org/apache/cocoon/generation/HttpProxyGenerator.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- HttpProxyGenerator.java 16 Mar 2003 17:49:06 -0000 1.2
+++ HttpProxyGenerator.java 5 Jul 2003 04:27:27 -0000 1.3
@@ -127,7 +127,9 @@
this.method = new GetMethod();
} else if ("POST".equalsIgnoreCase(method)) {
this.method = new PostMethod();
- /* Work around a bug from the HttpClient library */
+ /* TODO: Is this still needed? Does it refer to a bug in bugzilla?
+ * At least the handling in httpclient has completely changed.
+ * Work around a bug from the HttpClient library */
((PostMethod) this.method).setRequestBody("");
} else {
throw new ConfigurationException("Invalid method \"" + method + "\" specified"
@@ -251,7 +253,9 @@
public void recycle() {
/* Recycle the method */
this.method.recycle();
- /* Work around a bug from the HttpClient library */
+ /* TODO: Is this still needed? Does it refer to a bug in bugzilla?
+ * At least the handling in httpclient has completely changed.
+ * Work around a bug from the HttpClient library */
if (this.method instanceof PostMethod) ((PostMethod) this.method).setRequestBody("");
/* Clean up our parent */