You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Henry Jen <he...@ztune.net> on 2006/03/30 21:46:19 UTC
[PATCH] dbd.m4: use LDFLAGS instead of LIBS is required on Solaris
Hi,
AC_CHECK_LIB is performed as "$CC $CFLAGS $LDFLAGS -llib $LIBS conftest.c"
With Sun Studio, -L needs to be in front of -l flag, which makes sense
when you need control on which lib to be linked with.
In dbd.m4, using LIBS to define the -L flag, which should really be
LDFLAGS, the attached patch does just that.
Please help to review and commit the patch. Much appreciated.
Cheers,
Henry
Re: [PATCH] dbd.m4: use LDFLAGS instead of LIBS is required on Solaris
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On 3/30/06, William A. Rowe, Jr. <wr...@rowe-clan.net> wrote:
> Henry Jen wrote:
> > @@ -40,7 +40,7 @@
> > apu_have_pgsql=0
> > else
> > CPPFLAGS="-I$withval/include"
> > - LIBS="-L$withval/lib "
> > + LDFLAGS="-L$withval/lib "
>
> +1 - this was LIBS abuse - your solution is correct :)
Agreed, committed in r390268.
Thanks!
-garrett
Re: [PATCH] dbd.m4: use LDFLAGS instead of LIBS is required on Solaris
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Henry Jen wrote:
> @@ -40,7 +40,7 @@
> apu_have_pgsql=0
> else
> CPPFLAGS="-I$withval/include"
> - LIBS="-L$withval/lib "
> + LDFLAGS="-L$withval/lib "
+1 - this was LIBS abuse - your solution is correct :)
Bill