[PR] [ISSUE#6071] bound SMTP socket timeouts for notification email [rocketmq-dashboard]

["Kris20030907 (via GitHub)" <gi...@apache.org>]

Kris20030907 opened a new pull request, #6072:
URL: https://github.com/apache/rocketmq-dashboard/pull/6072

   <!-- Make sure the base branch is `master`: that is the RocketMQ Studio trunk. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Link the issue with a keyword so it closes on merge. Trivial fixes need no issue.
        https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue -->
   
   - Fixes #6071
   
   ### Brief Description
   
   <!-- What changes and why. Keep it short — the diff already shows how. -->
   
   ### How Did You Test This Change?
   
   <!-- Paste the commands you ran and what they printed. Typical verification:
        backend  `cd server && mvn -B -ntp test`   (integration tests need MySQL 8, see CONTRIBUTING.md)
        frontend `cd web && npm test && npm run lint && npm run build`
        A pull request with no verification will not be merged. -->
   
   ### Checklist
   
   - [ ] One coherent change; unrelated modifications are not bundled in
   - [ ] Commit subject follows Conventional Commits (`feat:` / `fix:` / `refactor:` / `chore:` / `docs:` / `perf:`)
   - [ ] Tests added or updated for non-trivial changes, test methods named `...Test`
   - [ ] New UI text has both Chinese and English entries under `web/src/i18n/`
   - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit checks)
   - [ ] New source files carry the ASF license header
   - [ ] Documentation touched where behaviour changed (README / `docs/` / in-app help)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE#6071] bound SMTP socket timeouts for notification email [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins commented on PR #6072:
URL: https://github.com/apache/rocketmq-dashboard/pull/6072#issuecomment-6120370391

   Thanks — this is merged, as part of [`b7704c6db`](https://github.com/apache/rocketmq-dashboard/commit/b7704c6dbfed0f59c3a052be65c685c3c75da2af) on `rocketmq-studio`.
   
   Your change went in together with #6121 — all yours, all in the same area — so we folded them into a single commit instead of landing several near-identical entries for the same subsystem. Nothing was dropped.
   
   The commit message calls this one out explicitly:
   
   > #6072 JavaMail's three socket timeouts default to infinite, and `NotificationOutboxService.sendEmail` (`:477-489`) calls `sender.send(message)` directly from the `@Scheduled` dispatcher at `:306` and the cleanup job at `:325`; the repo configures no `spring.task.scheduling` pool and defines no custom `TaskScheduler` bean, so Boot's default pool size of 1 means an SMTP relay that accepts the connection and never sends a 220 banner pins the backend's only scheduling thread forever — stopping notification dispatch, outbox cleanup and every other scheduled job with no log line to explain it → `application.yml:25-27` adds `mail.smtp.connectiontimeout`, `mail.smtp.timeout` and `mail.smtp.writetimeout` under the existing `spring.mail.properties` block, each overridable through `STUDIO_ALERTING_SMTP_CONNECTION_TIMEOUT` / `_READ_TIMEOUT` / `_WRITE_TIMEOUT` with 5000/10000/10000 ms defaults, and `docs/studio-native-alerting-design.md:266-268` lists the three next to the `STUDIO_ALERTI
 NG_SMTP_*` variables it already enumerated; this completes an invariant the same service already held, since the webhook channel bounds connect and read at 3 s / 5 s (`:675-679`) and `studio.metrics.prometheus` at `application.yml:99-100`.
   
   Closing as folded, not rejected.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE#6071] bound SMTP socket timeouts for notification email [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #6072: [ISSUE#6071] bound SMTP socket timeouts for notification email
URL: https://github.com/apache/rocketmq-dashboard/pull/6072


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org