You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/08/30 07:03:26 UTC
[GitHub] [incubator-hugegraph-toolchain] simon824 opened a new pull request, #331: fix checkstyle and enable checkstyle plugin
simon824 opened a new pull request, #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331
closed #330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] simon824 commented on pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
simon824 commented on PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#issuecomment-1250884395
hi @imbajin, please take a look at this pr when free ,thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin merged pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r1030487102
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/structure/constant/T.java:
##########
@@ -21,6 +21,6 @@
public class T {
- public static final String id = "id";
- public static final String label = "label";
+ public static final String ID = "id";
+ public static final String LABEL = "label";
Review Comment:
maybe to adapt code style for the const var
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#issuecomment-1231286172
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#331](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff432e3) into [master](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/c091e6b62a61cf2eeccb7af291ff98647e7f0b2e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c091e6b) will **decrease** coverage by `5.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #331 +/- ##
============================================
- Coverage 72.72% 67.49% -5.24%
+ Complexity 1849 877 -972
============================================
Files 242 86 -156
Lines 8104 4024 -4080
Branches 717 475 -242
============================================
- Hits 5894 2716 -3178
+ Misses 1827 1104 -723
+ Partials 383 204 -179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../java/com/baidu/hugegraph/driver/GraphManager.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvZHJpdmVyL0dyYXBoTWFuYWdlci5qYXZh) | | |
| [...com/baidu/hugegraph/exception/ServerException.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvZXhjZXB0aW9uL1NlcnZlckV4Y2VwdGlvbi5qYXZh) | | |
| [...java/com/baidu/hugegraph/structure/constant/T.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc3RydWN0dXJlL2NvbnN0YW50L1QuamF2YQ==) | | |
| [...java/com/baidu/hugegraph/structure/graph/Path.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc3RydWN0dXJlL2dyYXBoL1BhdGguamF2YQ==) | | |
| [...baidu/hugegraph/structure/auth/HugePermission.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc3RydWN0dXJlL2F1dGgvSHVnZVBlcm1pc3Npb24uamF2YQ==) | | |
| [...baidu/hugegraph/api/traverser/NeighborRankAPI.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvYXBpL3RyYXZlcnNlci9OZWlnaGJvclJhbmtBUEkuamF2YQ==) | | |
| [.../main/java/com/baidu/hugegraph/util/TaskCache.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvdXRpbC9UYXNrQ2FjaGUuamF2YQ==) | | |
| [...ph/structure/traverser/CustomizedPathsRequest.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc3RydWN0dXJlL3RyYXZlcnNlci9DdXN0b21pemVkUGF0aHNSZXF1ZXN0LmphdmE=) | | |
| [...om/baidu/hugegraph/structure/auth/LoginResult.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc3RydWN0dXJlL2F1dGgvTG9naW5SZXN1bHQuamF2YQ==) | | |
| [.../baidu/hugegraph/structure/constant/Traverser.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWNsaWVudC9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvc3RydWN0dXJlL2NvbnN0YW50L1RyYXZlcnNlci5qYXZh) | | |
| ... and [146 more](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/331/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] simon824 commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
simon824 commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r983037159
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/example/MovieExample.java:
##########
@@ -56,14 +56,22 @@ public static void main(String[] args) {
GraphManager graph = hugeClient.graph();
- Vertex theMatrix = graph.addVertex(T.label, "movie", "title", "The Matrix", "released", 1999);
- Vertex keanu = graph.addVertex(T.label, "person", "name", "keanu Reeves", "born", 1964);
- Vertex carrie = graph.addVertex(T.label, "person", "name", "carrie-anne Moss", "born", 1967);
- Vertex laurence = graph.addVertex(T.label, "person", "name", "laurence Fishburne", "born", 1961);
- Vertex hugo = graph.addVertex(T.label, "person", "name", "hugo Weaving", "born", 1960);
- Vertex lillyW = graph.addVertex(T.label, "person", "name", "Lilly Wachowski", "born", 1967);
- Vertex lanaW = graph.addVertex(T.label, "person", "name", "Lana Wachowski", "born", 1965);
- Vertex joelS = graph.addVertex(T.label, "person", "name", "Joel Silver", "born", 1952);
+ Vertex theMatrix = graph.addVertex(T.LABEL,
+ "movie", "title", "The Matrix", "released", 1999);
+ Vertex keanu = graph.addVertex(T.LABEL,
+ "person", "name", "keanu Reeves", "born", 1964);
+ Vertex carrie = graph.addVertex(T.LABEL,
+ "person", "name", "carrie-anne Moss", "born", 1967);
+ Vertex laurence = graph.addVertex(T.LABEL,
+ "person", "name", "laurence Fishburne", "born", 1961);
+ Vertex hugo = graph.addVertex(T.LABEL,
+ "person", "name", "hugo Weaving", "born", 1960);
+ Vertex lillyW = graph.addVertex(T.LABEL,
+ "person", "name", "Lilly Wachowski", "born", 1967);
+ Vertex lanaW = graph.addVertex(T.LABEL,
+ "person", "name", "Lana Wachowski", "born", 1965);
+ Vertex joelS = graph.addVertex(T.LABEL,
+ "person", "name", "Joel Silver", "born", 1952);
Review Comment:
LineLength longer than 100 here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] simon824 commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
simon824 commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r959064997
##########
checkstyle.xml:
##########
@@ -2,86 +2,216 @@
<!DOCTYPE module PUBLIC
Review Comment:
This file copy from https://github.com/apache/incubator-hugegraph/blob/master/style/checkstyle.xml , to keep consistent with hg server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] coderzc commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
coderzc commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r1030378457
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/structure/constant/T.java:
##########
@@ -21,6 +21,6 @@
public class T {
- public static final String id = "id";
- public static final String label = "label";
+ public static final String ID = "id";
+ public static final String LABEL = "label";
Review Comment:
Why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r958624550
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/cmd/SubCommands.java:
##########
@@ -1058,17 +1060,17 @@ public List<HugeType> convert(String value) {
hugeTypes.add(HugeType.valueOf(type.toUpperCase()));
} catch (IllegalArgumentException e) {
throw new ParameterException(String.format(
- "Invalid --type '%s', valid value is 'all' or " +
- "combination of 'vertex,edge,vertex_label," +
- "edge_label,property_key,index_label'", type));
+ "Invalid --type '%s', valid value is 'all' or " +
Review Comment:
can we keep the origin style? prefer to keep consistent with server code--change the code style specification: cancel the strict restriction on indentation
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/cmd/SubCommands.java:
##########
@@ -1058,17 +1060,17 @@ public List<HugeType> convert(String value) {
hugeTypes.add(HugeType.valueOf(type.toUpperCase()));
} catch (IllegalArgumentException e) {
throw new ParameterException(String.format(
- "Invalid --type '%s', valid value is 'all' or " +
- "combination of 'vertex,edge,vertex_label," +
- "edge_label,property_key,index_label'", type));
+ "Invalid --type '%s', valid value is 'all' or " +
+ "combination of 'vertex,edge,vertex_label," +
+ "edge_label,property_key,index_label'", type));
}
}
return hugeTypes;
}
}
public static class AuthHugeTypeConverter
- implements IStringConverter<List<HugeType>> {
+ implements IStringConverter<List<HugeType>> {
Review Comment:
can we keep the origin style?
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/formatter/kgdumper/DumpKGFormatter.java:
##########
@@ -101,6 +101,7 @@ private String dumpEntity(JsonVertex vertex)
region.add(((String) edge.getTarget()).split(":", 2)[1]);
regionWeight.add(props.get("weight").toString());
break;
+ default:
Review Comment:
also add break
##########
hugegraph-tools/src/main/java/com/baidu/hugegraph/formatter/kgdumper/SignFS64.java:
##########
@@ -115,7 +137,7 @@ private static String longBytes2String(ByteBuffer buffer) {
}
public static String createSignFs64(String text, String encode)
- throws UnsupportedEncodingException {
+ throws UnsupportedEncodingException {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r975167635
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/example/MovieExample.java:
##########
@@ -56,14 +56,22 @@ public static void main(String[] args) {
GraphManager graph = hugeClient.graph();
- Vertex theMatrix = graph.addVertex(T.label, "movie", "title", "The Matrix", "released", 1999);
- Vertex keanu = graph.addVertex(T.label, "person", "name", "keanu Reeves", "born", 1964);
- Vertex carrie = graph.addVertex(T.label, "person", "name", "carrie-anne Moss", "born", 1967);
- Vertex laurence = graph.addVertex(T.label, "person", "name", "laurence Fishburne", "born", 1961);
- Vertex hugo = graph.addVertex(T.label, "person", "name", "hugo Weaving", "born", 1960);
- Vertex lillyW = graph.addVertex(T.label, "person", "name", "Lilly Wachowski", "born", 1967);
- Vertex lanaW = graph.addVertex(T.label, "person", "name", "Lana Wachowski", "born", 1965);
- Vertex joelS = graph.addVertex(T.label, "person", "name", "Joel Silver", "born", 1952);
+ Vertex theMatrix = graph.addVertex(T.LABEL,
+ "movie", "title", "The Matrix", "released", 1999);
+ Vertex keanu = graph.addVertex(T.LABEL,
+ "person", "name", "keanu Reeves", "born", 1964);
+ Vertex carrie = graph.addVertex(T.LABEL,
+ "person", "name", "carrie-anne Moss", "born", 1967);
+ Vertex laurence = graph.addVertex(T.LABEL,
+ "person", "name", "laurence Fishburne", "born", 1961);
+ Vertex hugo = graph.addVertex(T.LABEL,
+ "person", "name", "hugo Weaving", "born", 1960);
+ Vertex lillyW = graph.addVertex(T.LABEL,
+ "person", "name", "Lilly Wachowski", "born", 1967);
+ Vertex lanaW = graph.addVertex(T.LABEL,
+ "person", "name", "Lana Wachowski", "born", 1965);
+ Vertex joelS = graph.addVertex(T.LABEL,
+ "person", "name", "Joel Silver", "born", 1952);
Review Comment:
seems no need to wrap new line in 59~74
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/example/MovieExample.java:
##########
@@ -73,10 +81,12 @@ public static void main(String[] args) {
lanaW.addEdge("DIRECTED", theMatrix, "score", 10);
joelS.addEdge("PRODUCED", theMatrix, "score", 10);
- Vertex emil = graph.addVertex(T.label, "person", "name", "emil Eifrem", "born", 1978);
+ Vertex emil = graph.addVertex(T.LABEL, "person", "name", "emil Eifrem", "born", 1978);
emil.addEdge("ACTED_IN", theMatrix, "roles", "emil");
- Vertex theMatrixReloaded = graph.addVertex(T.label, "movie", "title", "The Matrix Reloaded", "released", 2003);
+ Vertex theMatrixReloaded = graph.addVertex(T.LABEL,
+ "movie", "title",
+ "The Matrix Reloaded", "released", 2003);
Review Comment:
Is it a rule? Seems a little strange?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #331: fix checkstyle and enable checkstyle plugin
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #331:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/331#discussion_r990630149
##########
hugegraph-client/src/main/java/com/baidu/hugegraph/example/MovieExample.java:
##########
@@ -56,14 +56,22 @@ public static void main(String[] args) {
GraphManager graph = hugeClient.graph();
- Vertex theMatrix = graph.addVertex(T.label, "movie", "title", "The Matrix", "released", 1999);
- Vertex keanu = graph.addVertex(T.label, "person", "name", "keanu Reeves", "born", 1964);
- Vertex carrie = graph.addVertex(T.label, "person", "name", "carrie-anne Moss", "born", 1967);
- Vertex laurence = graph.addVertex(T.label, "person", "name", "laurence Fishburne", "born", 1961);
- Vertex hugo = graph.addVertex(T.label, "person", "name", "hugo Weaving", "born", 1960);
- Vertex lillyW = graph.addVertex(T.label, "person", "name", "Lilly Wachowski", "born", 1967);
- Vertex lanaW = graph.addVertex(T.label, "person", "name", "Lana Wachowski", "born", 1965);
- Vertex joelS = graph.addVertex(T.label, "person", "name", "Joel Silver", "born", 1952);
+ Vertex theMatrix = graph.addVertex(T.LABEL,
+ "movie", "title", "The Matrix", "released", 1999);
+ Vertex keanu = graph.addVertex(T.LABEL,
+ "person", "name", "keanu Reeves", "born", 1964);
+ Vertex carrie = graph.addVertex(T.LABEL,
+ "person", "name", "carrie-anne Moss", "born", 1967);
+ Vertex laurence = graph.addVertex(T.LABEL,
+ "person", "name", "laurence Fishburne", "born", 1961);
+ Vertex hugo = graph.addVertex(T.LABEL,
+ "person", "name", "hugo Weaving", "born", 1960);
+ Vertex lillyW = graph.addVertex(T.LABEL,
+ "person", "name", "Lilly Wachowski", "born", 1967);
+ Vertex lanaW = graph.addVertex(T.LABEL,
+ "person", "name", "Lana Wachowski", "born", 1965);
+ Vertex joelS = graph.addVertex(T.LABEL,
+ "person", "name", "Joel Silver", "born", 1952);
Review Comment:
OK, keep them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org