[GitHub] [beam] mutianf commented on a diff in pull request #24015: [Bigtable] Migrate BigtableIO to use the veneer client under the hood

["mutianf (via GitHub)" <gi...@apache.org>]

mutianf commented on code in PR #24015:
URL: https://github.com/apache/beam/pull/24015#discussion_r1108816978


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableConfig.java:
##########
@@ -115,6 +120,11 @@ BigtableConfig withTableId(ValueProvider<String> tableId) {
     return toBuilder().setTableId(tableId).build();
   }
 
+  BigtableConfig withAppProfileId(@Nullable ValueProvider<String> appProfileId) {
+    checkArgument(appProfileId != null, "App profile id can not be null");

Review Comment:
   Just trying to be consistent with other setters, we can clean this up in a separate pr! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org