[GitHub] [cassandra] dcapwell commented on a change in pull request #813: CASSANDRA-16256 - jvm dtest is strroperties which causes upgrade tests to fail

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #813:
URL: https://github.com/apache/cassandra/pull/813#discussion_r520144800



##########
File path: test/distributed/org/apache/cassandra/distributed/impl/Instance.java
##########
@@ -530,7 +530,10 @@ private void mkdirs()
     private Config loadConfig(IInstanceConfig overrides)
     {
         Map<String,Object> params = ((InstanceConfig) overrides).getParams();
-        return YamlConfigurationLoader.fromMap(params, Config.class);
+        boolean check = true;
+        if (overrides.get("dtest.api.config.check") != null)

Review comment:
       changed, but also moved the cluster_id one (same pattern) to a new Constants class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org