You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "pjanuario (via GitHub)" <gi...@apache.org> on 2025/05/19 12:34:37 UTC
[PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
pjanuario opened a new pull request, #1614:
URL: https://github.com/apache/polaris/pull/1614
While following the quickstart for jdbc the instructions are incomplete, this change adds missing env variables so that your can follow the instructions to launch a jdbc connected instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2095886994
##########
getting-started/jdbc/README.md:
##########
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
export QUARKUS_DATASOURCE_USERNAME=postgres
export QUARKUS_DATASOURCE_PASSWORD=postgres
+ export CLIENT_ID=root
+ export CLIENT_SECRET=s3cr3t
Review Comment:
The secret comes from `getting-started/jdbc/docker-compose-bootstrap-db.yml` (added under #1470).
Having this value set up front creates a backwards logical dependency, IMHO :thinking:
Since `docker-compose-postgres.yml` depends on the root secret and takes it from the user's env., I think `docker-compose-bootstrap-db.yml` should take the root secret from the user's env. too (and fail if it is not provided).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "pjanuario (via GitHub)" <gi...@apache.org>.
pjanuario commented on PR #1614:
URL: https://github.com/apache/polaris/pull/1614#issuecomment-2900890479
Closing this in favour of #1646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2096334002
##########
getting-started/jdbc/README.md:
##########
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
export QUARKUS_DATASOURCE_USERNAME=postgres
export QUARKUS_DATASOURCE_PASSWORD=postgres
+ export CLIENT_ID=root
+ export CLIENT_SECRET=s3cr3t
Review Comment:
@pjanuario : You initial fix works fine. I'm just suggesting to improve it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "pjanuario (via GitHub)" <gi...@apache.org>.
pjanuario commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2096188152
##########
getting-started/jdbc/README.md:
##########
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
export QUARKUS_DATASOURCE_USERNAME=postgres
export QUARKUS_DATASOURCE_PASSWORD=postgres
+ export CLIENT_ID=root
+ export CLIENT_SECRET=s3cr3t
Review Comment:
I am starting with the product and I might be doing something wrong, but as new user I followed this jdbc tutorial as starting point and if we follow it, the service `polaris-setup` invokes the `polaris/create_catalog.sh` script that requires this secrets to be passed in order to create quickstart catalog.
This will fail because it doesnt have credentials, the log entries are i mentioned in #1613 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #1614:
URL: https://github.com/apache/polaris/pull/1614#issuecomment-2892070458
#1610 seems to offer a more holistic fix for the same problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2096090403
##########
getting-started/jdbc/README.md:
##########
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
export QUARKUS_DATASOURCE_USERNAME=postgres
export QUARKUS_DATASOURCE_PASSWORD=postgres
+ export CLIENT_ID=root
+ export CLIENT_SECRET=s3cr3t
Review Comment:
+1, the spark client [here](https://github.com/apache/polaris/blob/main/getting-started/jdbc/docker-compose.yml#L85) passed creds here, can you please share what your command is to start docker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1614:
URL: https://github.com/apache/polaris/pull/1614#discussion_r2095822320
##########
getting-started/jdbc/README.md:
##########
@@ -40,6 +40,8 @@ This example requires `jq` to be installed on your machine.
export QUARKUS_DATASOURCE_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
export QUARKUS_DATASOURCE_USERNAME=postgres
export QUARKUS_DATASOURCE_PASSWORD=postgres
+ export CLIENT_ID=root
+ export CLIENT_SECRET=s3cr3t
Review Comment:
Could you give some more details about why this is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613) [polaris]
Posted by "pjanuario (via GitHub)" <gi...@apache.org>.
pjanuario closed pull request #1614: fix(quickstart): fixed quickstart jdbc to include client id and secrets (#1613)
URL: https://github.com/apache/polaris/pull/1614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org