You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Dag H. Wanvik (JIRA)" <ji...@apache.org> on 2007/09/14 01:48:32 UTC
[jira] Created: (DERBY-3073) SQL roles: add parser support
SQL roles: add parser support
-----------------------------
Key: DERBY-3073
URL: https://issues.apache.org/jira/browse/DERBY-3073
Project: Derby
Issue Type: New Feature
Components: SQL
Reporter: Dag H. Wanvik
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Derby Info: [Existing Application Impact, Release Note Needed] (was: [Release Note Needed, Existing Application Impact, Patch Available])
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073b.stat
DERBY-3073b.diff
Uploading DERBY-3073 once more, this time *with* the new test. Thanks for looking at it Rick!
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-3073.
----------------------------------
Resolution: Fixed
Derby Info: [Existing Application Impact, Release Note Needed] (was: [Release Note Needed, Existing Application Impact])
Committed follow-up patch DERBY-3073-part3 as svn 594822, resolving again.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Derby Info: [Patch Available, Existing Application Impact, Release Note Needed] (was: [Release Note Needed, Existing Application Impact])
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073b.stat
DERBY-3073b.diff
This patch, DERBY-3073b, replaces DERBY-3073.
The previous version had some issues which are corrected in this version:
- Parser support for create synonym was accidentally broken in the first
version.
- The look-ahead handling introduced to differentiate between granting of roles
and granting of privileges was broken. The new version is hopefully adequate.
- A test is now included (lang/RolesTest.java).
With this patch, the parser modifications should be completed as per the
specification in DERBY-2207, i.e. support for:
- create role
- drop role
- grant role
- revoke role
- set role
- current_role as value specification
- current_role as column default
All new features presently give "not implemented" (0A000: NOT_IMPLEMENTED) at
run-time if running with sql authorization, otherwise an error message (42Z60:
LANG_GRANT_REVOKE_WITH_LEGACY_ACCESS) is given.
Also, for all new features, if the database is pre-10.4, level (in soft upgrade
mode), an error is given (XCL47: LANG_STATEMENT_UPGRADE_REQUIRED).
All regression tests pass, including the new test.
As for the upgrade check, I have only tested manually so far. It will be added to upgrade tests
later.
It is ready for review; I will appreciate any comments!
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536963 ]
Dag H. Wanvik commented on DERBY-3073:
--------------------------------------
Thanks for looking at this Rick!
Tests ran ok, committing as svn 587458.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-3073:
---------------------------------
Derby Info: [Existing Application Impact] (was: [Existing Application Impact, Release Note Needed])
I am unchecking the "Release Note Needed" box because these changes have been disabled in the 10.4 branch.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532701 ]
Rick Hillegas commented on DERBY-3073:
--------------------------------------
Hi Dag,
I think that you may need to svn add RolesTest to your patch. It's not in the 3073b patch and this makes the build burp.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Component/s: Security
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073-part3.diff
Moved the upgrade check before the standard authorization check
consistently for role statements.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Hillegas updated DERBY-3073:
---------------------------------
Derby Info: (was: [Existing Application Impact])
Unchecking "Existing Application Impact" for the same reason.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536759 ]
Rick Hillegas commented on DERBY-3073:
--------------------------------------
Hi Dag,
Looks uncontroversial to me. +1.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532710 ]
Rick Hillegas commented on DERBY-3073:
--------------------------------------
Thanks for these improvements, Dag. The parser code is much more readable now that you have abstracted the LOOKAHEAD logic into a separate method.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reopened DERBY-3073:
----------------------------------
Reopening this issue to add a follow-up patch.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Derby Info: [Patch Available]
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584913#action_12584913 ]
Dag H. Wanvik commented on DERBY-3073:
--------------------------------------
Thanks for checking the doc patch, Rick!
Committed DERBY-3073-added-reserved-keywords as svn 644107 on documentation trunk.
Will backport to 10.4 docs as well.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-added-reserved-keywords.diff, DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533844 ]
Rick Hillegas commented on DERBY-3073:
--------------------------------------
Thanks, Dag. DERBY-3073c looks good to me.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073-part4.stat
DERBY-3073-part4.diff
Uploading DERBY-3073-part4, which:
- lifts restriction on role names to 30 chars; it is now 128 as
for other identifiers, cf. discussion with Dan in DERBY-2207.
- reserves the SYS prefix on role names
RolesTest is updated with modified/new tests for this.
Running regression tests now.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-3073.
----------------------------------
Resolution: Fixed
Derby Info: [Existing Application Impact, Release Note Needed] (was: [Release Note Needed, Existing Application Impact, Patch Available])
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571321#action_12571321 ]
Dag H. Wanvik commented on DERBY-3073:
--------------------------------------
DERBY-3073-part4 committed as svn 630124.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073-part-2.diff
This small patch, DERBY-3073-part-2, adds the following to the parser:
- check that role identifiers are max 30. Until the restriction of max
30 is lifted for user identifiers, role identifier should follow
suit, since both are authorization identifiers. Role identifiers
will be present along with user identifiers in the permission
catalogs, for which the limit is documented as 30.
- add the possibility that SET ROLE can take a string argument.
Presently, it accepts an identifier, a dynamic parameter
marker('?') or NONE.
Actually, the SQL standard specifies that both SET ROLE and SET
SCHEMA should take <value specification>, which *precludes* the use
on an identifier argument. But since SET SCHEMA is liberal, I elect
to make SET ROLE liberal too (keeping the possibility to specify
an identifier).
An extra test case for SET ROLE <string> is also added. Not for commit yet,
running tests.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-3073.
----------------------------------
Resolution: Fixed
Fix Version/s: 10.4.0.0
Derby Info: [Existing Application Impact, Release Note Needed] (was: [Patch Available])
Resolving, committed patch DERBY-3073c as svn 584738.
Marking with "existing application impact", because the patch
introduces two new reserved keywords: CURRENT_ROLE and NONE.
There will be one release note which covers all of the roles
work as part of DERBY-2207.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik resolved DERBY-3073.
----------------------------------
Resolution: Fixed
Derby Info: [Existing Application Impact, Release Note Needed] (was: [Release Note Needed, Existing Application Impact])
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073.stat
DERBY-3073.diff
Uploading a patch for parser changes for roles, DERBY-3073.{diff,stat}.
Not for commit yet, no tests in this patch.
The patch should implement all the required changes described in the functional specification attached to DERBY-2207, version 4.0.
Checks for sqlAuthorization and sufficient database level (>=10.4) have
been added for all role operations.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584695#action_12584695 ]
Rick Hillegas commented on DERBY-3073:
--------------------------------------
Thanks, Dag. I have applied the patch. It builds cleanly and looks good to me.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-added-reserved-keywords.diff, DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DERBY-3073) SQL roles: add parser
support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532838 ]
dagw edited comment on DERBY-3073 at 10/6/07 1:42 AM:
---------------------------------------------------------------
Uploading DERBY-3073b once more, this time *with* the new test. Thanks for looking at it Rick!
was (Author: dagw):
Uploading DERBY-3073 once more, this time *with* the new test. Thanks for looking at it Rick!
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571348#action_12571348 ]
Dag H. Wanvik commented on DERBY-3073:
--------------------------------------
Committed a small fix to sqlgrammar.jj as 630149.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Derby Info: [Patch Available, Existing Application Impact, Release Note Needed] (was: [Existing Application Impact, Release Note Needed])
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reopened DERBY-3073:
----------------------------------
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reassigned DERBY-3073:
------------------------------------
Assignee: Dag H. Wanvik
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik reopened DERBY-3073:
----------------------------------
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073c.stat
DERBY-3073c.diff
Uploading DERBY-3073c, which replaces earlier patches. The only
change relative to DERBY-3073b is an extra test for
SET ROLE ? syntax. I consider the patch complete by now,
please review :)
All regression tests passed.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-3073:
---------------------------------
Attachment: DERBY-3073-added-reserved-keywords.diff
Uploaded doc patch for new reserved keywords.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-added-reserved-keywords.diff, DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (DERBY-3073) SQL roles: add parser
support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542287 ]
dagw edited comment on DERBY-3073 at 11/13/07 4:12 PM:
----------------------------------------------------------------
Moved the upgrade check before the standard authorization check
consistently for role statements (DERBY-3073-part3).
was (Author: dagw):
Moved the upgrade check before the standard authorization check
consistently for role statements.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584928#action_12584928 ]
Dag H. Wanvik commented on DERBY-3073:
--------------------------------------
Backported DERBY-3073-added-reserved-keywords to 10.4 doc branch as svn 644116.
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: Security, SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Fix For: 10.4.0.0
>
> Attachments: DERBY-3073-added-reserved-keywords.diff, DERBY-3073-part-2.diff, DERBY-3073-part3.diff, DERBY-3073-part4.diff, DERBY-3073-part4.stat, DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat, DERBY-3073c.diff, DERBY-3073c.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3073) SQL roles: add parser support
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532844 ]
Dag H. Wanvik commented on DERBY-3073:
--------------------------------------
I notice I forgot to add a test for prepare of "SET ROLE ?".
I can make another revision of 3073, or add it later.
I added the dynamic capability for symmetry with "SET SCHEMA ?", is it
useful?
> SQL roles: add parser support
> -----------------------------
>
> Key: DERBY-3073
> URL: https://issues.apache.org/jira/browse/DERBY-3073
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Reporter: Dag H. Wanvik
> Assignee: Dag H. Wanvik
> Attachments: DERBY-3073.diff, DERBY-3073.stat, DERBY-3073b.diff, DERBY-3073b.diff, DERBY-3073b.stat, DERBY-3073b.stat
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.