[jira] [Commented] (STORM-693) KafkaBolt exception handling improvement

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344095#comment-14344095 ] 

ASF GitHub Bot commented on STORM-693:
--------------------------------------

GitHub user Parth-Brahmbhatt opened a pull request:

    https://github.com/apache/storm/pull/453

    STORM-693: when bolt fails to write tuple, it should report error instea...

    ...d of silently acking.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Parth-Brahmbhatt/incubator-storm STORM-693

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #453
    
----
commit aadccb4cb2a6602651d31542ecf2c96d72a0edfa
Author: Parth Brahmbhatt <br...@gmail.com>
Date:   2015-03-03T00:06:58Z

    STORM-693: when bolt fails to write tuple, it should report error instead of silently acking.

----


> KafkaBolt exception handling improvement
> ----------------------------------------
>
>                 Key: STORM-693
>                 URL: https://issues.apache.org/jira/browse/STORM-693
>             Project: Apache Storm
>          Issue Type: Bug
>          Components: storm-kafka
>    Affects Versions: 0.9.3
>            Reporter: Rick Kellogg
>
> Within the KafkaBolt execute method, an error message is logged if any sort of error occurs communicating with Kafka.  Unfortunately the input is still acknowledged.
> Upon review of the HdfsBolt & HiveBolt, I believe the exception handling block should include the following two lines:
>             this.collector.reportError(ex);
>             this.collector.fail(input);



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)