You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/10 09:53:25 UTC

[GitHub] [spark] MaxGekk opened a new pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

MaxGekk opened a new pull request #32121:
URL: https://github.com/apache/spark/pull/32121


   ### What changes were proposed in this pull request?
   1. Map Catalyst's interval types to Hive's types:
       - YearMonthIntervalType -> `interval_year_month`
       - DayTimeIntervalType -> `interval_day_time`
   2. Convert external interval types collected from Spark to Hive's types:
       - java.time.Period -> HiveIntervalYearMonth
       - java.time.Duration -> HiveIntervalDayTime
   
   ### Why are the changes needed?
   1. To be able to retrieve ANSI intervals via Hive Thrift server.
   2. This fixes the issue:
   ```sql
    $ ./sbin/start-thriftserver.sh
    $ ./bin/beeline
   Beeline version 2.3.8 by Apache Hive
   beeline> !connect jdbc:hive2://localhost:10000/default "" "" ""
   Connecting to jdbc:hive2://localhost:10000/default
   Connected to: Spark SQL (version 3.2.0-SNAPSHOT)
   0: jdbc:hive2://localhost:10000/default> select timestamp'2021-01-01 01:02:03.000001' - date'2020-12-31';
   Error: java.lang.IllegalArgumentException: Unrecognized type name: day-time interval (state=,code=0)
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   Yes. After the changes:
   ```sql
   0: jdbc:hive2://localhost:10000/default> select timestamp'2021-01-01 01:02:03.000001' - date'2020-12-31';
   +----------------------------------------------------+
   | subtracttimestamps(TIMESTAMP '2021-01-01 01:02:03.000001', DATE '2020-12-31') |
   +----------------------------------------------------+
   | 1 01:02:03.000001000                               |
   +----------------------------------------------------+
   1 row selected (1.637 seconds)
   ```
   
   ### How was this patch tested?
   By running new test:
   ```
   $ ./build/sbt -Phive -Phive-thriftserver "test:testOnly *SparkThriftServerProtocolVersionsSuite"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817128117


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41746/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817334110


   **[Test build #137181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137181/testReport)** for PR 32121 at commit [`feeeea5`](https://github.com/apache/spark/commit/feeeea5a2d2672c274ba626ddf1c31f6d082efc4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611205596



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -122,6 +124,12 @@ private[hive] class SparkExecuteStatementOperation(
           timeFormatters)
       case _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
         to += toHiveString((from.get(ordinal), dataTypes(ordinal)), false, timeFormatters)
+      case YearMonthIntervalType =>

Review comment:
       If I do as you propose, I get the exception on my test:
   ```
   [info]   Cause: java.lang.ClassCastException: java.lang.String cannot be cast to org.apache.hadoop.hive.common.type.HiveIntervalDayTime
   [info]   at org.apache.hive.service.cli.ColumnValue.toTColumnValue(ColumnValue.java:174)
   [info]   at org.apache.hive.service.cli.RowBasedSet.addRow(RowBasedSet.java:60)
   [info]   at org.apache.hive.service.cli.RowBasedSet.addRow(RowBasedSet.java:32)
   ```
   at
   ```java
       case INTERVAL_YEAR_MONTH_TYPE:
         return stringValue((HiveIntervalYearMonth) value);
       case INTERVAL_DAY_TIME_TYPE:
         return stringValue((HiveIntervalDayTime) value);
   ```
   Probably, I could just replace the casting by string casting. Let me try.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611207763



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -122,6 +124,12 @@ private[hive] class SparkExecuteStatementOperation(
           timeFormatters)
       case _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
         to += toHiveString((from.get(ordinal), dataTypes(ordinal)), false, timeFormatters)
+      case YearMonthIntervalType =>

Review comment:
       done

##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -25,6 +25,7 @@ import scala.collection.JavaConverters._
 import scala.collection.mutable.ArrayBuffer
 import scala.util.control.NonFatal
 
+import org.apache.hadoop.hive.common.`type`.{HiveIntervalDayTime, HiveIntervalYearMonth}

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817500407


   late LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32121:
URL: https://github.com/apache/spark/pull/32121


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611188787



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -122,6 +124,12 @@ private[hive] class SparkExecuteStatementOperation(
           timeFormatters)
       case _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
         to += toHiveString((from.get(ordinal), dataTypes(ordinal)), false, timeFormatters)
+      case YearMonthIntervalType =>

Review comment:
       I mean the client-side get the plain YearMonthIntervalType/DayTimeIntervalType values via `HiveIntervalYearMonth/DayTimeIntervalType`.toString, but the ones that in nested types are handled in `toHiveString`. They look the same but these branches seem to be redundant and may cause inconsistency if the underlying hive changed
   
   Is 
   ```scala
   case YearMonthIntervalType | DayTimeIntervalType  | _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
   ```
   better as we handle them consistently at spark-side?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817120417


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137168/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817128117


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41746/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817118071


   **[Test build #137168 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137168/testReport)** for PR 32121 at commit [`1c6c93d`](https://github.com/apache/spark/commit/1c6c93d394c69dab0cd7bc500b04938542963c5a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611186612



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -25,6 +25,7 @@ import scala.collection.JavaConverters._
 import scala.collection.mutable.ArrayBuffer
 import scala.util.control.NonFatal
 
+import org.apache.hadoop.hive.common.`type`.{HiveIntervalDayTime, HiveIntervalYearMonth}

Review comment:
       Add `HiveIntervalDayTime` and `HiveIntervalYearMonth ` to https://github.com/apache/spark/blob/d7dc42d5f6bbe861c7e4ac1bb49e0830af5e19f4/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetTypeInfoOperation.scala#L97-L103?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817342310






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817444315


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817113393


   **[Test build #137168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137168/testReport)** for PR 32121 at commit [`1c6c93d`](https://github.com/apache/spark/commit/1c6c93d394c69dab0cd7bc500b04938542963c5a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611159655



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -122,6 +124,12 @@ private[hive] class SparkExecuteStatementOperation(
           timeFormatters)
       case _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
         to += toHiveString((from.get(ordinal), dataTypes(ordinal)), false, timeFormatters)
+      case YearMonthIntervalType =>

Review comment:
       For example, after the PR https://github.com/apache/spark/pull/32120 is merged:
   ```sql
   0: jdbc:hive2://localhost:10000/default> select array(timestamp'2021-01-01 01:02:03.000001' - date'2020-12-31');
   +----------------------------------------------------+
   | array(subtracttimestamps(TIMESTAMP '2021-01-01 01:02:03.000001', DATE '2020-12-31')) |
   +----------------------------------------------------+
   | [1 01:02:03.000001000]                             |
   +----------------------------------------------------+
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817113393


   **[Test build #137168 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137168/testReport)** for PR 32121 at commit [`1c6c93d`](https://github.com/apache/spark/commit/1c6c93d394c69dab0cd7bc500b04938542963c5a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817339586


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41759/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611024841



##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
##########
@@ -458,5 +459,17 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftServer2TestBase {
         }
       }
     }
+
+    test(s"SPARK-35017: $version get day-time interval type") {

Review comment:
       I tested only day-time interval because constructing of year-month interval in SQL is not possible at the moment. I created the JIRA for that: SPARK-35018




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r616081505



##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
##########
@@ -458,5 +459,17 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftServer2TestBase {
         }
       }
     }
+
+    test(s"SPARK-35017: $version get day-time interval type") {

Review comment:
       The PR https://github.com/apache/spark/pull/32240 adds a test for year-month intervals.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611148067



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -122,6 +124,12 @@ private[hive] class SparkExecuteStatementOperation(
           timeFormatters)
       case _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
         to += toHiveString((from.get(ordinal), dataTypes(ordinal)), false, timeFormatters)
+      case YearMonthIntervalType =>

Review comment:
       If you mean the array, map types, they are converted to strings and they don't have a structure that could be recognized by Hive lib. Don't think I can do something here in the PR. This is a restriction of current implementation, and it should be solved in general way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on a change in pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #32121:
URL: https://github.com/apache/spark/pull/32121#discussion_r611119760



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala
##########
@@ -122,6 +124,12 @@ private[hive] class SparkExecuteStatementOperation(
           timeFormatters)
       case _: ArrayType | _: StructType | _: MapType | _: UserDefinedType[_] =>
         to += toHiveString((from.get(ordinal), dataTypes(ordinal)), false, timeFormatters)
+      case YearMonthIntervalType =>

Review comment:
       How about nested types? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817121758






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817342310






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817338975


   **[Test build #137181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137181/testReport)** for PR 32121 at commit [`feeeea5`](https://github.com/apache/spark/commit/feeeea5a2d2672c274ba626ddf1c31f6d082efc4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817334110


   **[Test build #137181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137181/testReport)** for PR 32121 at commit [`feeeea5`](https://github.com/apache/spark/commit/feeeea5a2d2672c274ba626ddf1c31f6d082efc4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32121: [SPARK-35017][SQL] Transfer ANSI intervals via Hive Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32121:
URL: https://github.com/apache/spark/pull/32121#issuecomment-817120417


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137168/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org