[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #12384: [Bug] [Service] Condition 'globalParamsMap != null' is always 'true'.

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #12384:
URL: https://github.com/apache/dolphinscheduler/pull/12384#discussion_r996387662


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/expand/CuringGlobalParams.java:
##########
@@ -157,7 +157,7 @@ public Map<String, Property> paramParsingPreparation(@NonNull TaskInstance taskI
         String timeZone = cmdParam.get(Constants.SCHEDULE_TIMEZONE);
         Map<String, String> params = BusinessTimeUtils.getBusinessTime(commandType, scheduleTime, timeZone);
 
-        if (globalParamsMap != null) {
+        if (!globalParamsMap.isEmpty()) {

Review Comment:
   ```suggestion
           if (MapUtils.isNotEmpty(globalParamsMap.isEmpty)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org