You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/30 19:52:59 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
xinyiZzz opened a new pull request, #13795:
URL: https://github.com/apache/doris/pull/13795
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #13795:
URL: https://github.com/apache/doris/pull/13795#discussion_r1009142766
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -58,6 +59,14 @@ class LoadChannelMgr {
// cancel all tablet stream for 'load_id' load
Status cancel(const PTabletWriterCancelRequest& request);
+ void refresh_mem_tracker() {
Review Comment:
why do we need refresh memtracker periodly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #13795:
URL: https://github.com/apache/doris/pull/13795#discussion_r1009366175
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -80,7 +89,8 @@ class LoadChannelMgr {
Cache* _last_success_channel = nullptr;
// check the total load channel mem consumption of this Backend
- std::shared_ptr<MemTrackerLimiter> _mem_tracker;
+ std::unique_ptr<MemTracker> _mem_tracker;
Review Comment:
Ditto~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on code in PR #13795:
URL: https://github.com/apache/doris/pull/13795#discussion_r1009223742
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -58,6 +59,14 @@ class LoadChannelMgr {
// cancel all tablet stream for 'load_id' load
Status cancel(const PTabletWriterCancelRequest& request);
+ void refresh_mem_tracker() {
Review Comment:
Because the normal mem tracker used by LoadChannelMgr has no parent-child relationship, the consumption of the MemTable tracker will not be automatically synchronized to the LoadChannelMgr tracker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13795:
URL: https://github.com/apache/doris/pull/13795#issuecomment-1296449458
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.58 seconds
load time: 605 seconds
storage size: 17182689332 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221031021453_clickbench_pr_35957.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #13795:
URL: https://github.com/apache/doris/pull/13795#discussion_r1009144221
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -80,7 +89,8 @@ class LoadChannelMgr {
Cache* _last_success_channel = nullptr;
// check the total load channel mem consumption of this Backend
- std::shared_ptr<MemTrackerLimiter> _mem_tracker;
+ std::unique_ptr<MemTracker> _mem_tracker;
Review Comment:
I think we should use MemTrackerLimiter here. Normal memtracker could be used to control flush memtable. But if it could not flush memtable accurately then limiter memtracker will work. If this is a normal memtracker, OOM will occurred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13795: [enhancement](memtracker) Refactor load channel + memtable mem tracker
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13795:
URL: https://github.com/apache/doris/pull/13795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org