You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/01/14 08:22:40 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #2867:
[GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC
transformation
autumnust opened a new pull request #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ]
- https://issues.apache.org/jira/browse/GOBBLIN-1024
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
Making Avro-to-ORC able to recognize logical types in source Avro schema and handle them properly.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request
#2867: [GOBBLIN-1024] Supporting Avro logical type recognition in
Avro-to-ORC transformation
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on a change in pull request #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#discussion_r366607210
##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/HiveAvroTypeConstants.java
##########
@@ -66,4 +66,17 @@
.put("date", ImmutableSet.<String>builder().add("string", "varchar").build())
.put("binary", Sets.<String>newHashSet())
.put("boolean", Sets.<String>newHashSet()).build();
+
+ /**
+ * Following are supported Avro logical types where they would be mapped to corresponding Hive types:
+ * Decimal -> "decimal"
+ * Date -> "date"
+ * TIME_MILLIS = "timestamp"
+ */
+ public static final String DECIMAL = "decimal";
+ public static final String DATE = "date";
+ public static final String TIME_MILLIS = "time-millis";
+
+ public static final Map<String, String> LOGICAL_TYPE_MAPPING = ImmutableMap
Review comment:
Where is this map be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on issue #2867:
[GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC
transformation
Posted by GitBox <gi...@apache.org>.
autumnust commented on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#issuecomment-574397433
> Unit tests failed, can you take a look at it?
I am not able to reproduce the issue locally, was thinking of triggering a new build after addressing comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2867:
[GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC
transformation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#issuecomment-574426534
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=h1) Report
> Merging [#2867](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/357d1db84c4601b3e50f7d26a05d8ce282c5159d?src=pr&el=desc) will **decrease** coverage by `41.65%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2867 +/- ##
============================================
- Coverage 45.75% 4.1% -41.66%
+ Complexity 9103 747 -8356
============================================
Files 1917 1917
Lines 72131 72197 +66
Branches 7956 7963 +7
============================================
- Hits 33003 2961 -30042
- Misses 36102 68917 +32815
+ Partials 3026 319 -2707
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/gobblin/util/HiveAvroTypeConstants.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGl2ZUF2cm9UeXBlQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=) | `0% <0%> (-94.83%)` | `0 <0> (-27)` | |
| [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `0% <0%> (-58.26%)` | `0 <0> (-81)` | |
| [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `0% <0%> (-64.52%)` | `0 <0> (-85)` | |
| [...n/converter/AvroStringFieldDecryptorConverter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tY3J5cHRvLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9BdnJvU3RyaW5nRmllbGREZWNyeXB0b3JDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
| [...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlVGhyZWFkTW9kZWwuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (-5%)` | |
| [...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL2F2cm8vQXZyb0tleUNvbXBhY3Rvck91dHB1dEZvcm1hdC5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
| [...apache/gobblin/fork/CopyNotSupportedException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZm9yay9Db3B5Tm90U3VwcG9ydGVkRXhjZXB0aW9uLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
| [.../gobblin/kafka/writer/KafkaWriterCommonConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbW1vbkNvbmZpZy5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (-7%)` | |
| [...ker/task/TaskLevelPolicyCheckerBuilderFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Rhc2svVGFza0xldmVsUG9saWN5Q2hlY2tlckJ1aWxkZXJGYWN0b3J5LmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
| ... and [1114 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=footer). Last update [357d1db...515f89a](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request
#2867: [GOBBLIN-1024] Supporting Avro logical type recognition in
Avro-to-ORC transformation
Posted by GitBox <gi...@apache.org>.
autumnust commented on a change in pull request #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#discussion_r366620914
##########
File path: gobblin-utility/src/main/java/org/apache/gobblin/util/HiveAvroTypeConstants.java
##########
@@ -66,4 +66,17 @@
.put("date", ImmutableSet.<String>builder().add("string", "varchar").build())
.put("binary", Sets.<String>newHashSet())
.put("boolean", Sets.<String>newHashSet()).build();
+
+ /**
+ * Following are supported Avro logical types where they would be mapped to corresponding Hive types:
+ * Decimal -> "decimal"
+ * Date -> "date"
+ * TIME_MILLIS = "timestamp"
+ */
+ public static final String DECIMAL = "decimal";
+ public static final String DATE = "date";
+ public static final String TIME_MILLIS = "time-millis";
+
+ public static final Map<String, String> LOGICAL_TYPE_MAPPING = ImmutableMap
Review comment:
Good catch, not being used anymore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2867:
[GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC
transformation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#issuecomment-574426534
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=h1) Report
> Merging [#2867](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/357d1db84c4601b3e50f7d26a05d8ce282c5159d?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `64.51%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2867 +/- ##
===========================================
+ Coverage 45.75% 45.8% +0.05%
- Complexity 9103 9108 +5
===========================================
Files 1917 1917
Lines 72131 72197 +66
Branches 7956 7963 +7
===========================================
+ Hits 33003 33070 +67
+ Misses 36102 36098 -4
- Partials 3026 3029 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/gobblin/util/HiveAvroTypeConstants.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGl2ZUF2cm9UeXBlQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `57.72% <0%> (-0.53%)` | `81 <0> (ø)` | |
| [...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=) | `94.64% <100%> (-0.19%)` | `26 <0> (-1)` | |
| [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `64.75% <73.07%> (+0.23%)` | `88 <0> (+3)` | :arrow_up: |
| [.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh) | `78.12% <0%> (-1.57%)` | `15% <0%> (-1%)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.81% <0%> (-0.47%)` | `28% <0%> (ø)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0%> (+1.42%)` | `4% <0%> (ø)` | :arrow_down: |
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `72.22% <0%> (+2.22%)` | `13% <0%> (ø)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=footer). Last update [357d1db...515f89a](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2867:
[GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC
transformation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867#issuecomment-574426534
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=h1) Report
> Merging [#2867](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/357d1db84c4601b3e50f7d26a05d8ce282c5159d?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `69.38%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2867 +/- ##
===========================================
+ Coverage 45.75% 45.8% +0.05%
- Complexity 9103 9109 +6
===========================================
Files 1917 1915 -2
Lines 72131 72262 +131
Branches 7956 7971 +15
===========================================
+ Hits 33003 33103 +100
- Misses 36102 36137 +35
+ Partials 3026 3022 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/gobblin/util/HiveAvroTypeConstants.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGl2ZUF2cm9UeXBlQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/gobblin/util/AvroUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXZyb1V0aWxzLmphdmE=) | `57.72% <0%> (-0.53%)` | `81 <0> (ø)` | |
| [...bblin/converter/filter/AvroSchemaFieldRemover.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29udmVydGVyL2ZpbHRlci9BdnJvU2NoZW1hRmllbGRSZW1vdmVyLmphdmE=) | `94.64% <100%> (-0.19%)` | `26 <0> (-1)` | |
| [...nversion/hive/query/HiveAvroORCQueryGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9xdWVyeS9IaXZlQXZyb09SQ1F1ZXJ5R2VuZXJhdG9yLmphdmE=) | `65.21% <75%> (+0.7%)` | `92 <3> (+7)` | :arrow_up: |
| [.../gobblin/cluster/GobblinHelixMessagingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TWVzc2FnaW5nU2VydmljZS5qYXZh) | `63.04% <0%> (-2.13%)` | `4% <0%> (ø)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0%> (-1.52%)` | `14% <0%> (-1%)` | |
| [.../org/apache/gobblin/test/SequentialTestSource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9TZXF1ZW50aWFsVGVzdFNvdXJjZS5qYXZh) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi93cml0ZXIvUGFycXVldEhkZnNEYXRhV3JpdGVyLmphdmE=) | | | |
| [...g/apache/gobblin/writer/ParquetHdfsDataWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tcGFycXVldC1hcGFjaGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vd3JpdGVyL1BhcnF1ZXRIZGZzRGF0YVdyaXRlci5qYXZh) | | | |
| [.../main/java/org/apache/gobblin/test/TestRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdGVzdC9UZXN0UmVjb3JkLmphdmE=) | | | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2867/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=footer). Last update [357d1db...5fbf44a](https://codecov.io/gh/apache/incubator-gobblin/pull/2867?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2867:
[GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC
transformation
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2867: [GOBBLIN-1024] Supporting Avro logical type recognition in Avro-to-ORC transformation
URL: https://github.com/apache/incubator-gobblin/pull/2867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services