[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3722: [CI] Skip CI when only docs are modified

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #3722: [CI] Skip CI when only docs are modified
URL: https://github.com/apache/skywalking/pull/3722#discussion_r339325334
 
 

 ##########
 File path: tools/ci/changed.sh
 ##########
 @@ -18,12 +18,18 @@
 
 patterns=()
 any_of=0
+all_of=0
 
+# --any-of: requires any of the changed files matche the given patterns
+# --all-of: requires all of the changed files matche the given patterns
 
 Review comment:
   this script is nothing related to the Jenkins logic from the file name `tools/ci/changed.sh`, it just determines whether (all of/any of) the files matching the given patterns changed or not, the usage sounds something like `do all of the changed files match the given patterns`, or `does any of the changed files match the given patterns`, `exclusion` seems also ok to me but may be less semantic 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services