[GitHub] [drill] paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework

[GitBox <gi...@apache.org>]

paul-rogers commented on a change in pull request #1899: DRILL-7445: Create batch copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r348113047
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2Builder.java
 ##########
 @@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.record.selection;
+
+import org.apache.drill.exec.memory.BufferAllocator;
+import org.apache.drill.exec.record.VectorContainer;
+
+public class SelectionVector2Builder {
 
 Review comment:
   That's where it is used in this PR. However, when doing the batch fixes, I found that we repeated the same logic (often incorrectly) in multiple places. The intent is to use this class in those cases as well. By putting it in this PR we can review it without also having to understand the operators that will eventually be changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services