You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/18 19:57:53 UTC

[GitHub] [hudi] nsivabalan commented on a diff in pull request #5344: [HUDI-3879]Suppress exceptions that are not fatal in HoodieMetadataTableValidator

nsivabalan commented on code in PR #5344:
URL: https://github.com/apache/hudi/pull/5344#discussion_r852372132


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java:
##########
@@ -399,7 +400,9 @@ public void doMetadataTableValidation() {
     Set<String> baseFilesForCleaning = Collections.emptySet();
 
     // check metadata table is available to read.
-    checkMetadataTableIsAvailable();
+    if (!checkMetadataTableIsAvailable()) {
+      return;
+    }

Review Comment:
   even if Metadata table does not have any commits, do we need to add an else block here and check that there are no completed commits in data table? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org