[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #822: HDDS-3390. Rebase OFS branch - 2

[GitBox <gi...@apache.org>]

smengcl commented on a change in pull request #822: HDDS-3390. Rebase OFS branch - 2
URL: https://github.com/apache/hadoop-ozone/pull/822#discussion_r410773493
 
 

 ##########
 File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java
 ##########
 @@ -186,6 +189,21 @@ public boolean isVolume() {
     return this.getBucketName().isEmpty() && !this.getVolumeName().isEmpty();
   }
 
+  private static String md5Hex(String input) {
+    try {
+      MessageDigest md = MessageDigest.getInstance("MD5");
+      byte[] digest = md.digest(input.getBytes());
 
 Review comment:
   I have implemented my own md5sum in OFSPath, but the check (findbugs) doesn't like it:
   ```
   Found reliance on default encoding in org.apache.hadoop.fs.ozone.OFSPath.md5Hex(String): String.getBytes()  At OFSPath.java:[line 195]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org