You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by hs...@apache.org on 2010/07/19 23:43:05 UTC

svn commit: r965649 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java

Author: hsaputra
Date: Mon Jul 19 21:43:04 2010
New Revision: 965649

URL: http://svn.apache.org/viewvc?rev=965649&view=rev
Log:
Patch from Mat Mannion | Disable HttpClient cookie handling

Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java?rev=965649&r1=965648&r2=965649&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/BasicHttpFetcher.java Mon Jul 19 21:43:04 2010
@@ -43,6 +43,8 @@ import org.apache.http.client.methods.Ht
 import org.apache.http.client.methods.HttpUriRequest;
 import org.apache.http.client.params.ClientPNames;
 import org.apache.http.client.params.HttpClientParams;
+import org.apache.http.client.protocol.RequestAddCookies;
+import org.apache.http.client.protocol.ResponseProcessCookies;
 import org.apache.http.conn.ClientConnectionManager;
 import org.apache.http.conn.ConnectionPoolTimeoutException;
 import org.apache.http.conn.HttpHostConnectException;
@@ -212,6 +214,10 @@ public class BasicHttpFetcher implements
     });
     client.setHttpRequestRetryHandler(new DefaultHttpRequestRetryHandler() );
 
+    // Disable automatic storage and sending of cookies (see SHINDIG-1382)
+    client.removeRequestInterceptorByClass(RequestAddCookies.class); 
+    client.removeResponseInterceptorByClass(ResponseProcessCookies.class);
+
     // Use Java's built-in proxy logic in case no proxy set via guice.
     if (StringUtils.isEmpty(basicHttpFetcherProxy)) {
       ProxySelectorRoutePlanner routePlanner = new ProxySelectorRoutePlanner(