You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2019/04/25 08:51:00 UTC

[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

    [ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585446#comment-16585446 ] 

Jacques Le Roux edited comment on OFBIZ-10438 at 4/25/19 8:50 AM:
------------------------------------------------------------------

Hi [~shi.jinghai]/[~rishisolankii] ,

As discussed on the dev mailing list, I am able to reproduce the issue on the local machine (Derby database) also using the SVN trunk code. Here are the steps to reproduce it:

1) Log in to the 'ordermgr' with admin/ofbiz credentials.

2) Click on the 'orderentry' menu.

3) Under the 'Sales Order' section provide the details as follows:

    Product Store: OFBiz E-Commerce Store
     Sales Channel: Web Channel
     User Login Id: admin
     Customer: Demo Customer

4) Click on the 'Continue' button on the top right on the section.

5) Leave the details on next page as it is and click on the 'Continue'.

6) Select the product 'WG-9943' and enter any quantity (say 1). Click on the 'Add To Cart' button.

7) On the next page select Color, Size and Unit of Measure. Click on 'Add To Cart' button again.

8) You will be landed to an error page saying: "
|{color:#ffffff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [additem]; this request does not exist or cannot be called directly.|

Please find the attached image 'URL-Error-additem.png' for your reference.

9) Now change the product to 'GZ-2644' and click on 'Add To Cart' button.

10) Click on the 'Quick Finalize Order' link on the top right corner.

11) Click on the radio button for selecting the shipping address.

12) You will be landed to an error page saying: "
|{color:#ffffff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [updateCheckoutOptions]; this request does not exist or cannot be called directly.|

Please find the attached image "URL-Error-SelectShipping.png" for your reference.

It might be possible that demo instance is not up-to-date with the latest code base and we are not able to regenerate it there. 


was (Author: deepak.nigam):
Hi [~shi.jinghai]/[~rishisolankii] ,

As discussed on the dev mailing list, I am able to reproduce the issue on the local machine (Derby database) also using the SVN trunk code. Here are the steps to reproduce it:

1) Log in to the 'ordermgr' with admin/ofbiz credentials.

2) Click on the 'orderentry' menu.

3) Under the 'Sales Order' section provide the details as follows:

    Product Store: OFBiz E-Commerce Store
    Sales Channel: Web Channel
    User Login Id: admin
    Customer: Demo Customer

4) Click on the 'Continue' button on the top right on the section.

5) Leave the details on next page as it is and click on the 'Continue'.

6) Select the product 'WG-9943' and enter any quantity (say 1). Click on the 'Add To Cart' button.

7) On the next page select Color, Size and Unit of Measure. Click on 'Add To Cart' button again.

8) You will be landed to an error page saying: "
|{color:#ffffff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [additem]; this request does not exist or cannot be called directly.|

"

Please find the attached image 'URL-Error-additem.png' for your reference.

9) Now change the product to 'GZ-2644' and click on 'Add To Cart' button.

10) Click on the 'Quick Finalize Order' link on the top right corner.

11) Click on the radio button for selecting the shipping address.

12) You will be landed to an error page saying: "
|{color:#ffffff}*:ERROR MESSAGE:*{color}|
|org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [updateCheckoutOptions]; this request does not exist or cannot be called directly.|

"

Please find the attached image "URL-Error-SelectShipping.png" for your reference.

 

It might be possible that demo instance is not up-to-date with the latest code base and we are not able to regenerate it there. 

 

 

 

 

 

> Add method attribute to request-map to controll a uri can be called GET or POST only
> ------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10438
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10438
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Shi Jinghai
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, OFBIZ-10438_0003-Handle-multiple-request-methods.patch, OFBIZ-10438_Fix-resolveURI.patch, URL-Error-SelectShipping.png, URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map element, it's almost the same as we implemented in our openapi:
> {code:java}
> <request-map uri="examples" method="get">
>    <security https="true" auth="true"/>
>    <event type="java" path="ExamplesHandlers" invoke="getExamples"/>
>    <response name="success" type="view" value="..."/>
>    <response name="error" type="view" value="..."/>
> </request-map>
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> <request-map uri="examples" method="get,post">...</request-map>
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)