You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/12/15 17:58:33 UTC
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23788
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Revert "IMPALA-14454: Exclude log4j 2 dependencies"
This reverts commit 52b87fcefd26dbf6fea751378bd23e0fb7e0d18a.
The original commit caused an issue when Impala is deployed together
with Apache Atlas. Coordinator failed to start with error message:
java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout
Solved minor conflict in impala-config.sh due to IMPALA-14478 applied
after IMPALA-14454.
Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
---
M bin/impala-config.sh
M fe/pom.xml
M java/executor-deps/pom.xml
M java/pom.xml
4 files changed, 29 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/23788/1
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23788 )
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12797/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:32:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23788 )
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:32:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23788 )
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23788/1/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/23788/1/fe/pom.xml@386
PS1, Line 386: <groupId>log4j</groupId>
This one's probably still not needed, but also doesn't hurt anything.
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 19:03:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23788 )
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Dec 2025 00:26:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23788 )
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Revert "IMPALA-14454: Exclude log4j 2 dependencies"
This reverts commit 52b87fcefd26dbf6fea751378bd23e0fb7e0d18a.
The original commit caused an issue when Impala is deployed together
with Apache Atlas. Coordinator failed to start with error message:
java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout
Solved minor conflict in impala-config.sh due to IMPALA-14478 applied
after IMPALA-14454.
Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Reviewed-on: http://gerrit.cloudera.org:8080/23788
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M java/executor-deps/pom.xml
M java/pom.xml
4 files changed, 29 insertions(+), 8 deletions(-)
Approvals:
Michael Smith: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-14454: Exclude log4j 2 dependencies"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23788 )
Change subject: Revert "IMPALA-14454: Exclude log4j 2 dependencies"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/21165/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77127db8d833c675c18c30eb3d6542ca906cd2a9
Gerrit-Change-Number: 23788
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 18:23:01 +0000
Gerrit-HasComments: No