You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/18 15:22:06 UTC

[GitHub] [avro] zcsizmadia opened a new pull request #1554: AVRO-3407: Add user_metadats interop tests in C#

zcsizmadia opened a new pull request #1554:
URL: https://github.com/apache/avro/pull/1554


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-3407
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] zcsizmadia commented on pull request #1554: AVRO-3407: Add user_metadats interop tests in C#

Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1554:
URL: https://github.com/apache/avro/pull/1554#issuecomment-1046046273


   Probably it was because I did a PR into your branch, which did not trigger the gitflow action, becuase it is triggered only when PR is made to master or changes to those PRs  (to master). Sorry if I overcomplicated 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g commented on pull request #1554: AVRO-3407: Add user_metadats interop tests in C#

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1554:
URL: https://github.com/apache/avro/pull/1554#issuecomment-1045928163


   The C# interop Github Actions checks didn't run for some reason.
   Merging ... 
   Let's see whether they will run in #1552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g merged pull request #1554: AVRO-3407: Add user_metadats interop tests in C#

Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1554:
URL: https://github.com/apache/avro/pull/1554


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g commented on pull request #1554: AVRO-3407: Add user_metadats interop tests in C#

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #1554:
URL: https://github.com/apache/avro/pull/1554#issuecomment-1046080051


   Right!
   I am in weekend mode, I don't think that far! :-)
   Thank you for your help here!
   
   On Sat, Feb 19, 2022, 17:46 Zoltan Csizmadia ***@***.***>
   wrote:
   
   > Probably it was because I did a PR into your branch, which did not trigger
   > the gitflow action, becuase it is triggered only when PR is made to master
   > or changes to those PRs (to master). Sorry if I overcomplicated
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/avro/pull/1554#issuecomment-1046046273>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AABYUQSJICMFQSU45PMWCWLU363LXANCNFSM5OYHN5HQ>
   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
   > or Android
   > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
   >
   > You are receiving this because you modified the open/close state.Message
   > ID: ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org